From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, "Kamil Horák - 2N" <kamilh@axis.com>,
florian.fainelli@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, andrew@lunn.ch,
hkallweit1@gmail.com
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, kamilh@axis.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] net: phy: bcm-phy-lib: Implement BroadR-Reach link modes
Date: Sat, 4 May 2024 15:18:37 +0300 [thread overview]
Message-ID: <586a9bc8-aa2a-4312-8936-a10f18e1f9ce@moroto.mountain> (raw)
In-Reply-To: <20240503083719.899312-4-kamilh@axis.com>
Hi Kamil,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kamil-Hor-k-2N/net-phy-bcm54811-New-link-mode-for-BroadR-Reach/20240503-164308
base: net/main
patch link: https://lore.kernel.org/r/20240503083719.899312-4-kamilh%40axis.com
patch subject: [PATCH v2 3/3] net: phy: bcm-phy-lib: Implement BroadR-Reach link modes
config: i386-randconfig-141-20240504 (https://download.01.org/0day-ci/archive/20240504/202405041037.sjZak003-lkp@intel.com/config)
compiler: clang version 18.1.4 (https://github.com/llvm/llvm-project e6c3289804a67ea0bb6a86fadbe454dd93b8d855)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202405041037.sjZak003-lkp@intel.com/
smatch warnings:
drivers/net/phy/broadcom.c:627 bcm5481x_config_delay_swap() error: uninitialized symbol 'ret'.
drivers/net/phy/broadcom.c:1249 bcm_read_master_slave() error: uninitialized symbol 'cfg'.
vim +/ret +627 drivers/net/phy/broadcom.c
f1e9c8e593d6ea Kamil Horák - 2N 2024-05-03 611 static int bcm5481x_config_delay_swap(struct phy_device *phydev)
57bb7e222804c6 Anton Vorontsov 2008-03-04 612 {
b14995ac2527b4 Jon Mason 2016-11-04 613 struct device_node *np = phydev->mdio.dev.of_node;
57bb7e222804c6 Anton Vorontsov 2008-03-04 614 int ret;
57bb7e222804c6 Anton Vorontsov 2008-03-04 615
f1e9c8e593d6ea Kamil Horák - 2N 2024-05-03 616 /* Set up the delay. */
042cb56478152b Tao Ren 2018-11-05 617 bcm54xx_config_clock_delay(phydev);
57bb7e222804c6 Anton Vorontsov 2008-03-04 618
b14995ac2527b4 Jon Mason 2016-11-04 619 if (of_property_read_bool(np, "enet-phy-lane-swap")) {
b14995ac2527b4 Jon Mason 2016-11-04 620 /* Lane Swap - Undocumented register...magic! */
b14995ac2527b4 Jon Mason 2016-11-04 621 ret = bcm_phy_write_exp(phydev, MII_BCM54XX_EXP_SEL_ER + 0x9,
b14995ac2527b4 Jon Mason 2016-11-04 622 0x11B);
b14995ac2527b4 Jon Mason 2016-11-04 623 if (ret < 0)
b14995ac2527b4 Jon Mason 2016-11-04 624 return ret;
b14995ac2527b4 Jon Mason 2016-11-04 625 }
"ret" not initialized on else path.
b14995ac2527b4 Jon Mason 2016-11-04 626
57bb7e222804c6 Anton Vorontsov 2008-03-04 @627 return ret;
Also "return 0;" is always better.
57bb7e222804c6 Anton Vorontsov 2008-03-04 628 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next parent reply other threads:[~2024-05-04 12:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240503083719.899312-4-kamilh@axis.com>
2024-05-04 12:18 ` Dan Carpenter [this message]
2024-05-04 2:33 [PATCH v2 3/3] net: phy: bcm-phy-lib: Implement BroadR-Reach link modes kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=586a9bc8-aa2a-4312-8936-a10f18e1f9ce@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=kamilh@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).