oe-kbuild.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: drivers/usb/musb/musb_dsps.c:850:9-34: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)
Date: Sat, 18 May 2024 05:01:43 +0800	[thread overview]
Message-ID: <202405180425.PLk75x8W-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Grant B Adams <nemith592@gmail.com>
CC: Tony Lindgren <tony@atomide.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7ee332c9f12bc5b380e36919cd7d056592a7073f
commit: 2f07592c30e1db498fe198a80e9d36f9d7cce441 usb: musb: dsps: Fix vbus vs tps65217-charger irq conflict
date:   8 months ago
:::::: branch date: 2 hours ago
:::::: commit date: 8 months ago
config: mips-randconfig-r052-20240517 (https://download.01.org/0day-ci/archive/20240518/202405180425.PLk75x8W-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project d3455f4ddd16811401fa153298fadd2f59f6914e)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202405180425.PLk75x8W-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/usb/musb/musb_dsps.c:850:9-34: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)

vim +850 drivers/usb/musb/musb_dsps.c

369469a92393d8 Tony Lindgren 2017-02-01  835  
369469a92393d8 Tony Lindgren 2017-02-01  836  static int dsps_setup_optional_vbus_irq(struct platform_device *pdev,
369469a92393d8 Tony Lindgren 2017-02-01  837  					struct dsps_glue *glue)
369469a92393d8 Tony Lindgren 2017-02-01  838  {
369469a92393d8 Tony Lindgren 2017-02-01  839  	int error;
369469a92393d8 Tony Lindgren 2017-02-01  840  
369469a92393d8 Tony Lindgren 2017-02-01  841  	glue->vbus_irq = platform_get_irq_byname(pdev, "vbus");
369469a92393d8 Tony Lindgren 2017-02-01  842  	if (glue->vbus_irq == -EPROBE_DEFER)
369469a92393d8 Tony Lindgren 2017-02-01  843  		return -EPROBE_DEFER;
369469a92393d8 Tony Lindgren 2017-02-01  844  
369469a92393d8 Tony Lindgren 2017-02-01  845  	if (glue->vbus_irq <= 0) {
369469a92393d8 Tony Lindgren 2017-02-01  846  		glue->vbus_irq = 0;
369469a92393d8 Tony Lindgren 2017-02-01  847  		return 0;
369469a92393d8 Tony Lindgren 2017-02-01  848  	}
369469a92393d8 Tony Lindgren 2017-02-01  849  
369469a92393d8 Tony Lindgren 2017-02-01 @850  	error = devm_request_threaded_irq(glue->dev, glue->vbus_irq,
369469a92393d8 Tony Lindgren 2017-02-01  851  					  NULL, dsps_vbus_threaded_irq,
2f07592c30e1db Grant B Adams 2023-08-23  852  					  IRQF_SHARED,
369469a92393d8 Tony Lindgren 2017-02-01  853  					  "vbus", glue);
369469a92393d8 Tony Lindgren 2017-02-01  854  	if (error) {
369469a92393d8 Tony Lindgren 2017-02-01  855  		glue->vbus_irq = 0;
369469a92393d8 Tony Lindgren 2017-02-01  856  		return error;
369469a92393d8 Tony Lindgren 2017-02-01  857  	}
369469a92393d8 Tony Lindgren 2017-02-01  858  	dev_dbg(glue->dev, "VBUS irq %i configured\n", glue->vbus_irq);
369469a92393d8 Tony Lindgren 2017-02-01  859  
369469a92393d8 Tony Lindgren 2017-02-01  860  	return 0;
369469a92393d8 Tony Lindgren 2017-02-01  861  }
369469a92393d8 Tony Lindgren 2017-02-01  862  

:::::: The code at line 850 was first introduced by commit
:::::: 369469a92393d8e365093d44c0df7a7b6430bc8b usb: musb: Add support for optional VBUS irq to dsps glue layer

:::::: TO: Tony Lindgren <tony@atomide.com>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-05-17 21:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202405180425.PLk75x8W-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=julia.lawall@inria.fr \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).