From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] hostfs: convert hostfs to use the new mount api
Date: Fri, 17 May 2024 11:54:38 +0800 [thread overview]
Message-ID: <202405171154.21q42SWy-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240513124141.3788846-1-lihongbo22@huawei.com>
References: <20240513124141.3788846-1-lihongbo22@huawei.com>
TO: Hongbo Li <lihongbo22@huawei.com>
TO: richard@nod.at
TO: anton.ivanov@cambridgegreys.com
TO: johannes@sipsolutions.net
CC: linux-um@lists.infradead.org
CC: linux-fsdevel@vger.kernel.org
CC: lihongbo22@huawei.com
Hi Hongbo,
kernel test robot noticed the following build warnings:
[auto build test WARNING on uml/next]
[also build test WARNING on wireless-next/main wireless/main linus/master v6.9 next-20240516]
[cannot apply to uml/fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Hongbo-Li/hostfs-convert-hostfs-to-use-the-new-mount-api/20240513-204233
base: git://git.kernel.org/pub/scm/linux/kernel/git/uml/linux next
patch link: https://lore.kernel.org/r/20240513124141.3788846-1-lihongbo22%40huawei.com
patch subject: [PATCH] hostfs: convert hostfs to use the new mount api
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
config: um-randconfig-r081-20240517 (https://download.01.org/0day-ci/archive/20240517/202405171154.21q42SWy-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project d3455f4ddd16811401fa153298fadd2f59f6914e)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202405171154.21q42SWy-lkp@intel.com/
smatch warnings:
fs/hostfs/hostfs_kern.c:960 hostfs_fill_super() error: uninitialized symbol 'host_root'.
vim +/host_root +960 fs/hostfs/hostfs_kern.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 937
2c2593890079e8 Hongbo Li 2024-05-13 938 static int hostfs_fill_super(struct super_block *sb, struct fs_context *fc)
^1da177e4c3f41 Linus Torvalds 2005-04-16 939 {
2c2593890079e8 Hongbo Li 2024-05-13 940 struct hostfs_fs_info *fsi = sb->s_fs_info;
^1da177e4c3f41 Linus Torvalds 2005-04-16 941 struct inode *root_inode;
2c2593890079e8 Hongbo Li 2024-05-13 942 char *host_root;
^1da177e4c3f41 Linus Torvalds 2005-04-16 943 int err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 944
^1da177e4c3f41 Linus Torvalds 2005-04-16 945 sb->s_blocksize = 1024;
^1da177e4c3f41 Linus Torvalds 2005-04-16 946 sb->s_blocksize_bits = 10;
^1da177e4c3f41 Linus Torvalds 2005-04-16 947 sb->s_magic = HOSTFS_SUPER_MAGIC;
^1da177e4c3f41 Linus Torvalds 2005-04-16 948 sb->s_op = &hostfs_sbops;
b26d4cd385fc51 Al Viro 2013-10-25 949 sb->s_d_op = &simple_dentry_operations;
752fa51e4c5182 Wolfgang Illmeyer 2009-06-30 950 sb->s_maxbytes = MAX_LFS_FILESIZE;
ce72750f04d68a Sjoerd Simons 2021-11-05 951 err = super_setup_bdi(sb);
ce72750f04d68a Sjoerd Simons 2021-11-05 952 if (err)
74ce793bcbde5c Mickaël Salaün 2023-06-12 953 return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 954
b58c4e96192ee7 Andy Shevchenko 2020-03-20 955 /* NULL is printed as '(null)' by printf(): avoid that. */
2c2593890079e8 Hongbo Li 2024-05-13 956 if (fc->source == NULL)
2c2593890079e8 Hongbo Li 2024-05-13 957 host_root = "";
^1da177e4c3f41 Linus Torvalds 2005-04-16 958
2c2593890079e8 Hongbo Li 2024-05-13 959 fsi->host_root_path =
2c2593890079e8 Hongbo Li 2024-05-13 @960 kasprintf(GFP_KERNEL, "%s/%s", root_ino, host_root);
2c2593890079e8 Hongbo Li 2024-05-13 961 if (fsi->host_root_path == NULL)
74ce793bcbde5c Mickaël Salaün 2023-06-12 962 return -ENOMEM;
^1da177e4c3f41 Linus Torvalds 2005-04-16 963
2c2593890079e8 Hongbo Li 2024-05-13 964 root_inode = hostfs_iget(sb, fsi->host_root_path);
74ce793bcbde5c Mickaël Salaün 2023-06-12 965 if (IS_ERR(root_inode))
74ce793bcbde5c Mickaël Salaün 2023-06-12 966 return PTR_ERR(root_inode);
52b209f7b848a2 Al Viro 2010-06-06 967
4754b825571a6f Al Viro 2010-06-06 968 if (S_ISLNK(root_inode->i_mode)) {
74ce793bcbde5c Mickaël Salaün 2023-06-12 969 char *name;
74ce793bcbde5c Mickaël Salaün 2023-06-12 970
74ce793bcbde5c Mickaël Salaün 2023-06-12 971 iput(root_inode);
2c2593890079e8 Hongbo Li 2024-05-13 972 name = follow_link(fsi->host_root_path);
74ce793bcbde5c Mickaël Salaün 2023-06-12 973 if (IS_ERR(name))
74ce793bcbde5c Mickaël Salaün 2023-06-12 974 return PTR_ERR(name);
74ce793bcbde5c Mickaël Salaün 2023-06-12 975
74ce793bcbde5c Mickaël Salaün 2023-06-12 976 root_inode = hostfs_iget(sb, name);
52b209f7b848a2 Al Viro 2010-06-06 977 kfree(name);
74ce793bcbde5c Mickaël Salaün 2023-06-12 978 if (IS_ERR(root_inode))
74ce793bcbde5c Mickaël Salaün 2023-06-12 979 return PTR_ERR(root_inode);
4754b825571a6f Al Viro 2010-06-06 980 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 981
48fde701aff662 Al Viro 2012-01-08 982 sb->s_root = d_make_root(root_inode);
^1da177e4c3f41 Linus Torvalds 2005-04-16 983 if (sb->s_root == NULL)
74ce793bcbde5c Mickaël Salaün 2023-06-12 984 return -ENOMEM;
^1da177e4c3f41 Linus Torvalds 2005-04-16 985
f1adc05e773830 Jeff Dike 2007-05-08 986 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 987 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 988
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-05-17 3:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 3:54 kernel test robot [this message]
[not found] <20240513124141.3788846-1-lihongbo22@huawei.com>
2024-05-17 11:01 ` [PATCH] hostfs: convert hostfs to use the new mount api Dan Carpenter
2024-05-17 11:21 ` Hongbo Li
2024-05-23 10:43 ` Dan Carpenter
2024-05-30 11:47 ` Hongbo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405171154.21q42SWy-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).