From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v8 3/3] pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver
Date: Sun, 12 May 2024 11:26:17 +0800 [thread overview]
Message-ID: <202405121133.eykxulmj-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240508065141.565848-4-ychuang570808@gmail.com>
References: <20240508065141.565848-4-ychuang570808@gmail.com>
TO: Jacky Huang <ychuang570808@gmail.com>
TO: linus.walleij@linaro.org
TO: robh+dt@kernel.org
TO: krzysztof.kozlowski+dt@linaro.org
TO: conor+dt@kernel.org
TO: p.zabel@pengutronix.de
TO: j.neuschaefer@gmx.net
CC: linux-arm-kernel@lists.infradead.org
CC: linux-gpio@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: ychuang3@nuvoton.com
CC: schung@nuvoton.com
Hi Jacky,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linusw-pinctrl/for-next pza/reset/next robh/for-next linus/master v6.9-rc7 next-20240510]
[cannot apply to pza/imx-drm/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Jacky-Huang/dt-bindings-reset-Add-syscon-to-nuvoton-ma35d1-system-management-node/20240508-145358
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
patch link: https://lore.kernel.org/r/20240508065141.565848-4-ychuang570808%40gmail.com
patch subject: [PATCH v8 3/3] pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
config: sparc-randconfig-r081-20240512 (https://download.01.org/0day-ci/archive/20240512/202405121133.eykxulmj-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202405121133.eykxulmj-lkp@intel.com/
smatch warnings:
drivers/pinctrl/nuvoton/pinctrl-ma35.c:665 ma35_pinconf_set_pull() error: uninitialized symbol 'pull_sel'.
vim +/pull_sel +665 drivers/pinctrl/nuvoton/pinctrl-ma35.c
cb3da13430a6b4 Jacky Huang 2024-05-08 637
cb3da13430a6b4 Jacky Huang 2024-05-08 638 static int ma35_pinconf_set_pull(struct ma35_pinctrl *npctl, unsigned int pin,
cb3da13430a6b4 Jacky Huang 2024-05-08 639 int pull_up)
cb3da13430a6b4 Jacky Huang 2024-05-08 640 {
cb3da13430a6b4 Jacky Huang 2024-05-08 641 unsigned int port, group_num;
cb3da13430a6b4 Jacky Huang 2024-05-08 642 void __iomem *base;
cb3da13430a6b4 Jacky Huang 2024-05-08 643 u32 regval, pull_sel;
cb3da13430a6b4 Jacky Huang 2024-05-08 644
cb3da13430a6b4 Jacky Huang 2024-05-08 645 ma35_gpio_cla_port(pin, &group_num, &port);
cb3da13430a6b4 Jacky Huang 2024-05-08 646 base = npctl->ctrl->pin_banks[group_num].reg_base;
cb3da13430a6b4 Jacky Huang 2024-05-08 647
cb3da13430a6b4 Jacky Huang 2024-05-08 648 regval = readl(base + MA35_GP_REG_PUSEL);
cb3da13430a6b4 Jacky Huang 2024-05-08 649 regval &= ~MA35_GP_PUSEL_MASK(port);
cb3da13430a6b4 Jacky Huang 2024-05-08 650
cb3da13430a6b4 Jacky Huang 2024-05-08 651 switch (pull_up) {
cb3da13430a6b4 Jacky Huang 2024-05-08 652 case PIN_CONFIG_BIAS_PULL_UP:
cb3da13430a6b4 Jacky Huang 2024-05-08 653 pull_sel = MA35_GP_PUSEL_PULL_UP;
cb3da13430a6b4 Jacky Huang 2024-05-08 654 break;
cb3da13430a6b4 Jacky Huang 2024-05-08 655
cb3da13430a6b4 Jacky Huang 2024-05-08 656 case PIN_CONFIG_BIAS_PULL_DOWN:
cb3da13430a6b4 Jacky Huang 2024-05-08 657 pull_sel = MA35_GP_PUSEL_PULL_DOWN;
cb3da13430a6b4 Jacky Huang 2024-05-08 658 break;
cb3da13430a6b4 Jacky Huang 2024-05-08 659
cb3da13430a6b4 Jacky Huang 2024-05-08 660 case PIN_CONFIG_BIAS_DISABLE:
cb3da13430a6b4 Jacky Huang 2024-05-08 661 pull_sel = MA35_GP_PUSEL_DISABLE;
cb3da13430a6b4 Jacky Huang 2024-05-08 662 break;
cb3da13430a6b4 Jacky Huang 2024-05-08 663 }
cb3da13430a6b4 Jacky Huang 2024-05-08 664
cb3da13430a6b4 Jacky Huang 2024-05-08 @665 regval |= field_prep(MA35_GP_PUSEL_MASK(port), pull_sel);
cb3da13430a6b4 Jacky Huang 2024-05-08 666 writel(regval, base + MA35_GP_REG_PUSEL);
cb3da13430a6b4 Jacky Huang 2024-05-08 667
cb3da13430a6b4 Jacky Huang 2024-05-08 668 return 0;
cb3da13430a6b4 Jacky Huang 2024-05-08 669 }
cb3da13430a6b4 Jacky Huang 2024-05-08 670
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-05-12 3:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405121133.eykxulmj-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).