oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: jasperwang@tencent.com, kaixuxia@tencent.com,
	frankjpliu@tencent.com, kasong@tencent.com,
	sagazchen@tencent.com, kernelxing@tencent.com,
	aurelianliu@tencent.com, jason.zeng@intel.com,
	wu.zheng@intel.com, yingbao.jia@intel.com, pei.p.jia@intel.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [opencloudos:next 6613/6620] arch/x86/kernel/csv-shared.c:130:13: warning: no previous prototype for 'csv3_scan_secure_call_pages'
Date: Wed, 15 May 2024 21:37:12 +0800	[thread overview]
Message-ID: <202405152116.GXE4qF7Y-lkp@intel.com> (raw)

tree:   https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git next
head:   24bcde27d3b11d99cdceaa28d2ba6213e1678e90
commit: edd662ef105a5ac2660cf545e73cf202894beb0c [6613/6620] x86/kernel: Add CSV3 early update(enc/dec)/reset memory helpers
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240515/202405152116.GXE4qF7Y-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240515/202405152116.GXE4qF7Y-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405152116.GXE4qF7Y-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from arch/x86/kernel/csv.c:15:
>> arch/x86/kernel/csv-shared.c:130:13: warning: no previous prototype for 'csv3_scan_secure_call_pages' [-Wmissing-prototypes]
     130 | void __init csv3_scan_secure_call_pages(struct boot_params *boot_params)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> arch/x86/kernel/csv-shared.c:177:13: warning: no previous prototype for 'csv3_early_secure_call_ident_map' [-Wmissing-prototypes]
     177 | void __init csv3_early_secure_call_ident_map(u64 base_address, u64 num_pages,
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/csv3_scan_secure_call_pages +130 arch/x86/kernel/csv-shared.c

9b3c8f4f8afc9e Xin Jiang 2024-03-11  122  
9b3c8f4f8afc9e Xin Jiang 2024-03-11  123  /**
9b3c8f4f8afc9e Xin Jiang 2024-03-11  124   * csv3_scan_secure_call_pages - try to find the secure call pages.
9b3c8f4f8afc9e Xin Jiang 2024-03-11  125   * @boot_params:	boot parameters where e820_table resides.
9b3c8f4f8afc9e Xin Jiang 2024-03-11  126   *
9b3c8f4f8afc9e Xin Jiang 2024-03-11  127   * The secure call pages are reserved by BIOS. We scan all the reserved pages
9b3c8f4f8afc9e Xin Jiang 2024-03-11  128   * to check the CSV3 secure call guid bytes.
9b3c8f4f8afc9e Xin Jiang 2024-03-11  129   */
9b3c8f4f8afc9e Xin Jiang 2024-03-11 @130  void __init csv3_scan_secure_call_pages(struct boot_params *boot_params)
9b3c8f4f8afc9e Xin Jiang 2024-03-11  131  {
9b3c8f4f8afc9e Xin Jiang 2024-03-11  132  	struct boot_e820_entry *entry;
9b3c8f4f8afc9e Xin Jiang 2024-03-11  133  	struct csv3_secure_call_cmd *sc_page;
9b3c8f4f8afc9e Xin Jiang 2024-03-11  134  	u64 offset;
9b3c8f4f8afc9e Xin Jiang 2024-03-11  135  	u64 addr;
9b3c8f4f8afc9e Xin Jiang 2024-03-11  136  	u8 i;
9b3c8f4f8afc9e Xin Jiang 2024-03-11  137  	u8 table_num;
9b3c8f4f8afc9e Xin Jiang 2024-03-11  138  	int count = 0;
9b3c8f4f8afc9e Xin Jiang 2024-03-11  139  
9b3c8f4f8afc9e Xin Jiang 2024-03-11  140  	if (!boot_params)
9b3c8f4f8afc9e Xin Jiang 2024-03-11  141  		return;
9b3c8f4f8afc9e Xin Jiang 2024-03-11  142  
9b3c8f4f8afc9e Xin Jiang 2024-03-11  143  	if (csv3_boot_sc_page_a != -1ul && csv3_boot_sc_page_b != -1ul)
9b3c8f4f8afc9e Xin Jiang 2024-03-11  144  		return;
9b3c8f4f8afc9e Xin Jiang 2024-03-11  145  
9b3c8f4f8afc9e Xin Jiang 2024-03-11  146  	table_num = min_t(u8, boot_params->e820_entries,
9b3c8f4f8afc9e Xin Jiang 2024-03-11  147  			  E820_MAX_ENTRIES_ZEROPAGE);
9b3c8f4f8afc9e Xin Jiang 2024-03-11  148  	entry = &boot_params->e820_table[0];
9b3c8f4f8afc9e Xin Jiang 2024-03-11  149  	for (i = 0; i < table_num; i++) {
9b3c8f4f8afc9e Xin Jiang 2024-03-11  150  		if (entry[i].type != E820_TYPE_RESERVED)
9b3c8f4f8afc9e Xin Jiang 2024-03-11  151  			continue;
9b3c8f4f8afc9e Xin Jiang 2024-03-11  152  
9b3c8f4f8afc9e Xin Jiang 2024-03-11  153  		addr = entry[i].addr & PAGE_MASK;
9b3c8f4f8afc9e Xin Jiang 2024-03-11  154  		for (offset = 0; offset < entry[i].size; offset += PAGE_SIZE) {
9b3c8f4f8afc9e Xin Jiang 2024-03-11  155  			sc_page = (void *)(addr + offset);
9b3c8f4f8afc9e Xin Jiang 2024-03-11  156  			if (sc_page->guid_64[0] == CSV3_SECURE_CALL_GUID_LOW &&
9b3c8f4f8afc9e Xin Jiang 2024-03-11  157  			    sc_page->guid_64[1] == CSV3_SECURE_CALL_GUID_HIGH) {
9b3c8f4f8afc9e Xin Jiang 2024-03-11  158  				if (count == 0)
9b3c8f4f8afc9e Xin Jiang 2024-03-11  159  					csv3_boot_sc_page_a = addr + offset;
9b3c8f4f8afc9e Xin Jiang 2024-03-11  160  				else if (count == 1)
9b3c8f4f8afc9e Xin Jiang 2024-03-11  161  					csv3_boot_sc_page_b = addr + offset;
9b3c8f4f8afc9e Xin Jiang 2024-03-11  162  				count++;
9b3c8f4f8afc9e Xin Jiang 2024-03-11  163  			}
9b3c8f4f8afc9e Xin Jiang 2024-03-11  164  			if (count >= 2)
9b3c8f4f8afc9e Xin Jiang 2024-03-11  165  				return;
9b3c8f4f8afc9e Xin Jiang 2024-03-11  166  		}
9b3c8f4f8afc9e Xin Jiang 2024-03-11  167  	}
9b3c8f4f8afc9e Xin Jiang 2024-03-11  168  }
9b3c8f4f8afc9e Xin Jiang 2024-03-11  169  
9b3c8f4f8afc9e Xin Jiang 2024-03-11  170  /**
9b3c8f4f8afc9e Xin Jiang 2024-03-11  171   * csv3_early_secure_call_ident_map - issue early secure call command at the
9b3c8f4f8afc9e Xin Jiang 2024-03-11  172   *			stage where identity page table is created.
9b3c8f4f8afc9e Xin Jiang 2024-03-11  173   * @base_address:	Start address of the specified memory range.
9b3c8f4f8afc9e Xin Jiang 2024-03-11  174   * @num_pages:		number of the specific pages.
9b3c8f4f8afc9e Xin Jiang 2024-03-11  175   * @cmd_type:		Secure call cmd type.
9b3c8f4f8afc9e Xin Jiang 2024-03-11  176   */
9b3c8f4f8afc9e Xin Jiang 2024-03-11 @177  void __init csv3_early_secure_call_ident_map(u64 base_address, u64 num_pages,

:::::: The code at line 130 was first introduced by commit
:::::: 9b3c8f4f8afc9e9143dcedcf81b1af63a0b4b381 x86/boot/compressed/64: Init CSV3 secure call pages

:::::: TO: Xin Jiang <jiangxin@hygon.cn>
:::::: CC: hanliyang <hanliyang@hygon.cn>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-05-15 13:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202405152116.GXE4qF7Y-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=aurelianliu@tencent.com \
    --cc=frankjpliu@tencent.com \
    --cc=jason.zeng@intel.com \
    --cc=jasperwang@tencent.com \
    --cc=kaixuxia@tencent.com \
    --cc=kasong@tencent.com \
    --cc=kernelxing@tencent.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pei.p.jia@intel.com \
    --cc=sagazchen@tencent.com \
    --cc=wu.zheng@intel.com \
    --cc=yingbao.jia@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).