oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: cros-kernel-buildreports@googlegroups.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [android-common:mirror-chromeos-5.10-arcvm 15/16] drivers/virtio/virtio_pvclock.c:244:42: error: invalid application of 'sizeof' to incomplete type 'struct pvclock_vsyscall_time_info'
Date: Wed, 15 May 2024 13:14:22 +0800	[thread overview]
Message-ID: <202405151339.waKKeTDO-lkp@intel.com> (raw)

tree:   https://android.googlesource.com/kernel/common mirror-chromeos-5.10-arcvm
head:   161aa0ad82f4cbd233d93470dbc4d33da26e8c5a
commit: 5f974515fd4a128e7c07fe36db373f468d31ef36 [15/16] CHROMIUM: virtio-pvclock driver for arm64.
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20240515/202405151339.waKKeTDO-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240515/202405151339.waKKeTDO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405151339.waKKeTDO-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/virtio/virtio_pvclock.c:69:6: warning: no previous prototype for 'update_suspend_time' [-Wmissing-prototypes]
      69 | void update_suspend_time(struct work_struct *work)
         |      ^~~~~~~~~~~~~~~~~~~
   drivers/virtio/virtio_pvclock.c: In function 'virtpvclock_probe':
>> drivers/virtio/virtio_pvclock.c:244:42: error: invalid application of 'sizeof' to incomplete type 'struct pvclock_vsyscall_time_info'
     244 |                                    sizeof(*virtio_pvclock_page),
         |                                          ^
   drivers/virtio/virtio_pvclock.c:270:51: error: invalid application of 'sizeof' to incomplete type 'struct pvclock_vsyscall_time_info'
     270 |         dma_free_coherent(vdev->dev.parent, sizeof(*virtio_pvclock_page),
         |                                                   ^
   drivers/virtio/virtio_pvclock.c: In function 'virtpvclock_remove':
   drivers/virtio/virtio_pvclock.c:293:51: error: invalid application of 'sizeof' to incomplete type 'struct pvclock_vsyscall_time_info'
     293 |         dma_free_coherent(vdev->dev.parent, sizeof(*virtio_pvclock_page),
         |                                                   ^


vim +244 drivers/virtio/virtio_pvclock.c

2b1ff8683a4370 Hikaru Nishida   2023-02-28  225  
2b1ff8683a4370 Hikaru Nishida   2023-02-28  226  static int virtpvclock_probe(struct virtio_device *vdev)
2b1ff8683a4370 Hikaru Nishida   2023-02-28  227  {
2b1ff8683a4370 Hikaru Nishida   2023-02-28  228  	struct virtio_pvclock *vp;
2b1ff8683a4370 Hikaru Nishida   2023-02-28  229  	int err;
2b1ff8683a4370 Hikaru Nishida   2023-02-28  230  
2b1ff8683a4370 Hikaru Nishida   2023-02-28  231  	if (!vdev->config->get) {
2b1ff8683a4370 Hikaru Nishida   2023-02-28  232  		dev_err(&vdev->dev, "%s: config access disabled\n", __func__);
2b1ff8683a4370 Hikaru Nishida   2023-02-28  233  		return -EINVAL;
2b1ff8683a4370 Hikaru Nishida   2023-02-28  234  	}
2b1ff8683a4370 Hikaru Nishida   2023-02-28  235  
2b1ff8683a4370 Hikaru Nishida   2023-02-28  236  	vp = kzalloc(sizeof(*vp), GFP_KERNEL);
2b1ff8683a4370 Hikaru Nishida   2023-02-28  237  	if (!vp) {
2b1ff8683a4370 Hikaru Nishida   2023-02-28  238  		err = -ENOMEM;
2b1ff8683a4370 Hikaru Nishida   2023-02-28  239  		goto out;
2b1ff8683a4370 Hikaru Nishida   2023-02-28  240  	}
2b1ff8683a4370 Hikaru Nishida   2023-02-28  241  
2b1ff8683a4370 Hikaru Nishida   2023-02-28  242  	virtio_pvclock_page =
2b1ff8683a4370 Hikaru Nishida   2023-02-28  243  		dma_alloc_coherent(vdev->dev.parent,
2b1ff8683a4370 Hikaru Nishida   2023-02-28 @244  				   sizeof(*virtio_pvclock_page),
2b1ff8683a4370 Hikaru Nishida   2023-02-28  245  				   &vp->pvclock_page_dma_addr, GFP_KERNEL);
2b1ff8683a4370 Hikaru Nishida   2023-02-28  246  
2b1ff8683a4370 Hikaru Nishida   2023-02-28  247  	if (!virtio_pvclock_page) {
2b1ff8683a4370 Hikaru Nishida   2023-02-28  248  		err = -ENOMEM;
2b1ff8683a4370 Hikaru Nishida   2023-02-28  249  		goto out_free_vp;
2b1ff8683a4370 Hikaru Nishida   2023-02-28  250  	}
2b1ff8683a4370 Hikaru Nishida   2023-02-28  251  
2b1ff8683a4370 Hikaru Nishida   2023-02-28  252  	INIT_WORK(&vp->update_suspend_time_work, update_suspend_time);
5f974515fd4a12 Suleiman Souhlal 2024-04-08  253  #ifdef CONFIG_X86
2b1ff8683a4370 Hikaru Nishida   2023-02-28  254  	INIT_WORK(&vp->create_clocksource_work, create_clocksource);
5f974515fd4a12 Suleiman Souhlal 2024-04-08  255  #endif
2b1ff8683a4370 Hikaru Nishida   2023-02-28  256  	mutex_init(&vp->inject_suspend_lock);
2b1ff8683a4370 Hikaru Nishida   2023-02-28  257  
2b1ff8683a4370 Hikaru Nishida   2023-02-28  258  	vp->vdev = vdev;
2b1ff8683a4370 Hikaru Nishida   2023-02-28  259  	vdev->priv = vp;
2b1ff8683a4370 Hikaru Nishida   2023-02-28  260  
2b1ff8683a4370 Hikaru Nishida   2023-02-28  261  	err = init_vqs(vp);
2b1ff8683a4370 Hikaru Nishida   2023-02-28  262  	if (err)
2b1ff8683a4370 Hikaru Nishida   2023-02-28  263  		goto out_free_pvclock_page;
2b1ff8683a4370 Hikaru Nishida   2023-02-28  264  
2b1ff8683a4370 Hikaru Nishida   2023-02-28  265  	virtio_device_ready(vdev);
2b1ff8683a4370 Hikaru Nishida   2023-02-28  266  
2b1ff8683a4370 Hikaru Nishida   2023-02-28  267  	return 0;
2b1ff8683a4370 Hikaru Nishida   2023-02-28  268  
2b1ff8683a4370 Hikaru Nishida   2023-02-28  269  out_free_pvclock_page:
2b1ff8683a4370 Hikaru Nishida   2023-02-28  270  	dma_free_coherent(vdev->dev.parent, sizeof(*virtio_pvclock_page),
2b1ff8683a4370 Hikaru Nishida   2023-02-28  271  			  virtio_pvclock_page, vp->pvclock_page_dma_addr);
2b1ff8683a4370 Hikaru Nishida   2023-02-28  272  
2b1ff8683a4370 Hikaru Nishida   2023-02-28  273  out_free_vp:
2b1ff8683a4370 Hikaru Nishida   2023-02-28  274  	kfree(vp);
2b1ff8683a4370 Hikaru Nishida   2023-02-28  275  out:
2b1ff8683a4370 Hikaru Nishida   2023-02-28  276  	return err;
2b1ff8683a4370 Hikaru Nishida   2023-02-28  277  }
2b1ff8683a4370 Hikaru Nishida   2023-02-28  278  

:::::: The code at line 244 was first introduced by commit
:::::: 2b1ff8683a4370ea8c1b01d801f8369ebd777e19 CHROMIUM: virtio_pvclock: port driver impl from Android

:::::: TO: Hikaru Nishida <hikalium@chromium.org>
:::::: CC: Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-05-15  5:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202405151339.waKKeTDO-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=cros-kernel-buildreports@googlegroups.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).