From: kernel test robot <lkp@intel.com>
To: Hannes Reinecke <hare@kernel.org>, Jens Axboe <axboe@kernel.dk>
Cc: oe-kbuild-all@lists.linux.dev,
Matthew Wilcox <willy@infradead.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Pankaj Raghav <p.raghav@samsung.com>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Hannes Reinecke <hare@kernel.org>
Subject: Re: [PATCH 5/6] block/bdev: lift restrictions on supported blocksize
Date: Wed, 15 May 2024 12:00:48 +0800 [thread overview]
Message-ID: <202405151142.8COQSJsa-lkp@intel.com> (raw)
In-Reply-To: <20240514173900.62207-6-hare@kernel.org>
Hi Hannes,
kernel test robot noticed the following build errors:
[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on linus/master v6.9]
[cannot apply to next-20240514]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Hannes-Reinecke/fs-mpage-avoid-negative-shift-for-large-blocksize/20240515-014146
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link: https://lore.kernel.org/r/20240514173900.62207-6-hare%40kernel.org
patch subject: [PATCH 5/6] block/bdev: lift restrictions on supported blocksize
config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20240515/202405151142.8COQSJsa-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240515/202405151142.8COQSJsa-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405151142.8COQSJsa-lkp@intel.com/
All errors (new ones prefixed by >>):
block/bdev.c: In function 'set_init_blocksize':
block/bdev.c:145:9: error: implicit declaration of function 'mapping_set_folio_min_order' [-Werror=implicit-function-declaration]
145 | mapping_set_folio_min_order(bdev->bd_inode->i_mapping,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
block/bdev.c: In function 'set_blocksize':
>> block/bdev.c:152:23: error: 'bs' undeclared (first use in this function); did you mean 'abs'?
152 | if (get_order(bs) > MAX_PAGECACHE_ORDER || size < 512 ||
| ^~
| abs
block/bdev.c:152:23: note: each undeclared identifier is reported only once for each function it appears in
cc1: some warnings being treated as errors
vim +152 block/bdev.c
148
149 int set_blocksize(struct block_device *bdev, int size)
150 {
151 /* Size must be a power of two, and between 512 and MAX_PAGECACHE_ORDER*/
> 152 if (get_order(bs) > MAX_PAGECACHE_ORDER || size < 512 ||
153 !is_power_of_2(size))
154 return -EINVAL;
155
156 /* Size cannot be smaller than the size supported by the device */
157 if (size < bdev_logical_block_size(bdev))
158 return -EINVAL;
159
160 /* Don't change the size if it is same as current */
161 if (bdev->bd_inode->i_blkbits != blksize_bits(size)) {
162 sync_blockdev(bdev);
163 bdev->bd_inode->i_blkbits = blksize_bits(size);
164 mapping_set_folio_min_order(bdev->bd_inode->i_mapping,
165 get_order(size));
166 kill_bdev(bdev);
167 }
168 return 0;
169 }
170
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2024-05-15 4:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240514173900.62207-6-hare@kernel.org>
2024-05-15 1:03 ` [PATCH 5/6] block/bdev: lift restrictions on supported blocksize kernel test robot
2024-05-15 4:00 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405151142.8COQSJsa-lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=hare@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mcgrof@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=p.raghav@samsung.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).