oe-kbuild-all.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: cros-kernel-buildreports@googlegroups.com,
	Guenter Roeck <groeck@google.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [chrome-os:chromeos-6.1 95/106] drivers/media/platform/mediatek/aie/mtk_aie_53.c:1804:12: warning: 'mtk_aie_resume' defined but not used
Date: Wed, 15 May 2024 01:31:20 +0800	[thread overview]
Message-ID: <202405150132.kBtWlGQY-lkp@intel.com> (raw)

tree:   https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-6.1
head:   1f64c8ce89e6d5c5cf094d47ae84dbc6956094a6
commit: 5cd0ae9700e0a1483b2fd161c7d7f120b643d953 [95/106] CHROMIUM: media: platform: mediatek: aie driver migration
config: arm-randconfig-002-20240515 (https://download.01.org/0day-ci/archive/20240515/202405150132.kBtWlGQY-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240515/202405150132.kBtWlGQY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405150132.kBtWlGQY-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/media/platform/mediatek/aie/mtk_aie_53.c:1804:12: warning: 'mtk_aie_resume' defined but not used [-Wunused-function]
    1804 | static int mtk_aie_resume(struct device *dev)
         |            ^~~~~~~~~~~~~~
>> drivers/media/platform/mediatek/aie/mtk_aie_53.c:1770:12: warning: 'mtk_aie_suspend' defined but not used [-Wunused-function]
    1770 | static int mtk_aie_suspend(struct device *dev)
         |            ^~~~~~~~~~~~~~~


vim +/mtk_aie_resume +1804 drivers/media/platform/mediatek/aie/mtk_aie_53.c

d2e4e2025dedbc Copy Chou 2023-10-18  1769  
d2e4e2025dedbc Copy Chou 2023-10-18 @1770  static int mtk_aie_suspend(struct device *dev)
d2e4e2025dedbc Copy Chou 2023-10-18  1771  {
d2e4e2025dedbc Copy Chou 2023-10-18  1772  	struct mtk_aie_dev *fd = dev_get_drvdata(dev);
d2e4e2025dedbc Copy Chou 2023-10-18  1773  	int ret = -EINVAL, num = 0;
d2e4e2025dedbc Copy Chou 2023-10-18  1774  
d2e4e2025dedbc Copy Chou 2023-10-18  1775  	if (pm_runtime_suspended(dev))
d2e4e2025dedbc Copy Chou 2023-10-18  1776  		return 0;
d2e4e2025dedbc Copy Chou 2023-10-18  1777  
d2e4e2025dedbc Copy Chou 2023-10-18  1778  	num = atomic_read(&fd->num_composing);
d2e4e2025dedbc Copy Chou 2023-10-18  1779  	dev_info(dev, "%s: suspend aie job start, num(%d)\n", __func__, num);
d2e4e2025dedbc Copy Chou 2023-10-18  1780  
d2e4e2025dedbc Copy Chou 2023-10-18  1781  	ret = wait_event_timeout(fd->flushing_waitq,
d2e4e2025dedbc Copy Chou 2023-10-18  1782  				 !(num = atomic_read(&fd->num_composing)),
d2e4e2025dedbc Copy Chou 2023-10-18  1783  				 msecs_to_jiffies(MTK_FD_HW_TIMEOUT_IN_MSEC)
d2e4e2025dedbc Copy Chou 2023-10-18  1784  		);
d2e4e2025dedbc Copy Chou 2023-10-18  1785  	if (!ret && num) {
d2e4e2025dedbc Copy Chou 2023-10-18  1786  		dev_dbg(dev,
d2e4e2025dedbc Copy Chou 2023-10-18  1787  			"%s: flushing aie job timeout num %d\n",
d2e4e2025dedbc Copy Chou 2023-10-18  1788  			__func__,
d2e4e2025dedbc Copy Chou 2023-10-18  1789  			num
d2e4e2025dedbc Copy Chou 2023-10-18  1790  		);
d2e4e2025dedbc Copy Chou 2023-10-18  1791  
d2e4e2025dedbc Copy Chou 2023-10-18  1792  		return -EBUSY;
d2e4e2025dedbc Copy Chou 2023-10-18  1793  	}
d2e4e2025dedbc Copy Chou 2023-10-18  1794  
d2e4e2025dedbc Copy Chou 2023-10-18  1795  	dev_info(dev, "%s: suspend aie job end num(%d)\n", __func__, num);
d2e4e2025dedbc Copy Chou 2023-10-18  1796  
d2e4e2025dedbc Copy Chou 2023-10-18  1797  	ret = pm_runtime_force_suspend(dev);
d2e4e2025dedbc Copy Chou 2023-10-18  1798  	if (ret)
d2e4e2025dedbc Copy Chou 2023-10-18  1799  		return ret;
d2e4e2025dedbc Copy Chou 2023-10-18  1800  
d2e4e2025dedbc Copy Chou 2023-10-18  1801  	return 0;
d2e4e2025dedbc Copy Chou 2023-10-18  1802  }
d2e4e2025dedbc Copy Chou 2023-10-18  1803  
d2e4e2025dedbc Copy Chou 2023-10-18 @1804  static int mtk_aie_resume(struct device *dev)
d2e4e2025dedbc Copy Chou 2023-10-18  1805  {
d2e4e2025dedbc Copy Chou 2023-10-18  1806  	int ret = -EINVAL;
d2e4e2025dedbc Copy Chou 2023-10-18  1807  
d2e4e2025dedbc Copy Chou 2023-10-18  1808  	dev_info(dev, "%s: resume aie job start)\n", __func__);
d2e4e2025dedbc Copy Chou 2023-10-18  1809  
d2e4e2025dedbc Copy Chou 2023-10-18  1810  	if (pm_runtime_suspended(dev)) {
d2e4e2025dedbc Copy Chou 2023-10-18  1811  		dev_info(dev,
d2e4e2025dedbc Copy Chou 2023-10-18  1812  			 "%s: pm_runtime_suspended is true, no action\n",
d2e4e2025dedbc Copy Chou 2023-10-18  1813  			 __func__
d2e4e2025dedbc Copy Chou 2023-10-18  1814  		);
d2e4e2025dedbc Copy Chou 2023-10-18  1815  		return 0;
d2e4e2025dedbc Copy Chou 2023-10-18  1816  	}
d2e4e2025dedbc Copy Chou 2023-10-18  1817  
d2e4e2025dedbc Copy Chou 2023-10-18  1818  	ret = pm_runtime_force_resume(dev);
d2e4e2025dedbc Copy Chou 2023-10-18  1819  	if (ret)
d2e4e2025dedbc Copy Chou 2023-10-18  1820  		return ret;
d2e4e2025dedbc Copy Chou 2023-10-18  1821  
d2e4e2025dedbc Copy Chou 2023-10-18  1822  	dev_info(dev, "%s: resume aie job end)\n", __func__);
d2e4e2025dedbc Copy Chou 2023-10-18  1823  	return 0;
d2e4e2025dedbc Copy Chou 2023-10-18  1824  }
d2e4e2025dedbc Copy Chou 2023-10-18  1825  

:::::: The code at line 1804 was first introduced by commit
:::::: d2e4e2025dedbc41046b5d9f4a8a209280f328f6 CHROMIUM: media: platform: mediatek: aie: Porting Kernel 6.1

:::::: TO: Copy Chou <copy.chou@mediatek.corp-partner.google.com>
:::::: CC: Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-05-14 17:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202405150132.kBtWlGQY-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=cros-kernel-buildreports@googlegroups.com \
    --cc=groeck@google.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).