From: kernel test robot <lkp@intel.com>
To: Murali Karicheri <m-karicheri2@ti.com>
Cc: oe-kbuild-all@lists.linux.dev, vigneshr@ti.com, nm@ti.com,
Praneeth Bajjuri <praneeth@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Ravi Gunasekaran <r-gunasekaran@ti.com>
Subject: [ti:ti-rt-linux-6.1.y-cicd 2/5] net/hsr/hsr_device.c:502:3-4: Unneeded semicolon
Date: Tue, 14 May 2024 05:55:51 +0800 [thread overview]
Message-ID: <202405140507.hbovyy3s-lkp@intel.com> (raw)
tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-6.1.y-cicd
head: 36746b42badc0d5707b84ccc34c5ea166c9573b2
commit: 7c2c6221d29ba79f1333ef18be4296f0ad542556 [2/5] net: hsr: Add VLAN CTAG filter support
config: x86_64-randconfig-101-20240513 (https://download.01.org/0day-ci/archive/20240514/202405140507.hbovyy3s-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405140507.hbovyy3s-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> net/hsr/hsr_device.c:502:3-4: Unneeded semicolon
net/hsr/hsr_device.c:526:3-4: Unneeded semicolon
vim +502 net/hsr/hsr_device.c
469
470 static int hsr_ndo_vlan_rx_add_vid(struct net_device *dev,
471 __be16 proto, u16 vid)
472 {
473 struct hsr_port *port;
474 struct hsr_priv *hsr;
475 int ret = 0;
476
477 hsr = netdev_priv(dev);
478
479 hsr_for_each_port(hsr, port) {
480 if (port->type == HSR_PT_MASTER)
481 continue;
482
483 ret = vlan_vid_add(port->dev, proto, vid);
484 switch (port->type) {
485 case HSR_PT_SLAVE_A:
486 if (ret) {
487 netdev_err(dev, "add vid failed for Slave-A\n");
488 return ret;
489 }
490 break;
491
492 case HSR_PT_SLAVE_B:
493 if (ret) {
494 /* clean up Slave-A */
495 netdev_err(dev, "add vid failed for Slave-B\n");
496 vlan_vid_del(port->dev, proto, vid);
497 return ret;
498 }
499 break;
500 default:
501 break;
> 502 };
503 }
504
505 return 0;
506 }
507
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-05-13 21:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405140507.hbovyy3s-lkp@intel.com \
--to=lkp@intel.com \
--cc=kishon@ti.com \
--cc=m-karicheri2@ti.com \
--cc=nm@ti.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=praneeth@ti.com \
--cc=r-gunasekaran@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).