From: kernel test robot <lkp@intel.com>
To: Lyndon Sanche <lsanche@lyndeno.ca>
Cc: oe-kbuild-all@lists.linux.dev, mario.limonciello@amd.com,
pali@kernel.org, W_Armin@gmx.de,
srinivas.pandruvada@linux.intel.com,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com
Subject: Re: [PATCH v2] platform/x86: dell-laptop: Implement platform_profile
Date: Tue, 14 May 2024 04:09:04 +0800 [thread overview]
Message-ID: <202405140348.Wz7gOmdP-lkp@intel.com> (raw)
In-Reply-To: <20240426020448.10862-1-lsanche@lyndeno.ca>
Hi Lyndon,
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on v6.9 next-20240513]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Lyndon-Sanche/platform-x86-dell-laptop-Implement-platform_profile/20240511-144534
base: linus/master
patch link: https://lore.kernel.org/r/20240426020448.10862-1-lsanche%40lyndeno.ca
patch subject: [PATCH v2] platform/x86: dell-laptop: Implement platform_profile
config: i386-randconfig-005-20240513 (https://download.01.org/0day-ci/archive/20240514/202405140348.Wz7gOmdP-lkp@intel.com/config)
compiler: gcc-8 (Ubuntu 8.4.0-3ubuntu2) 8.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240514/202405140348.Wz7gOmdP-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405140348.Wz7gOmdP-lkp@intel.com/
All errors (new ones prefixed by >>):
ld: drivers/platform/x86/dell/dell-laptop.o: in function `thermal_init':
>> drivers/platform/x86/dell/dell-laptop.c:2404:(.text+0x21a3): undefined reference to `platform_profile_register'
ld: drivers/platform/x86/dell/dell-laptop.o: in function `thermal_cleanup':
>> drivers/platform/x86/dell/dell-laptop.c:2412:(.text+0x21cc): undefined reference to `platform_profile_remove'
>> ld: drivers/platform/x86/dell/dell-laptop.c:2412:(.init.text+0xb44): undefined reference to `platform_profile_remove'
>> ld: drivers/platform/x86/dell/dell-laptop.c:2412:(.exit.text+0x7c): undefined reference to `platform_profile_remove'
vim +2404 drivers/platform/x86/dell/dell-laptop.c
2377
2378 int thermal_init(void)
2379 {
2380 int ret;
2381 int supported_modes;
2382
2383 ret = thermal_get_supported_modes(&supported_modes);
2384
2385 if (ret || !supported_modes)
2386 return 0;
2387
2388 thermal_handler = kzalloc(sizeof(*thermal_handler), GFP_KERNEL);
2389 if (!thermal_handler)
2390 return -ENOMEM;
2391 thermal_handler->profile_get = thermal_platform_profile_get;
2392 thermal_handler->profile_set = thermal_platform_profile_set;
2393
2394 if ((supported_modes >> DELL_QUIET) & 1)
2395 set_bit(PLATFORM_PROFILE_QUIET, thermal_handler->choices);
2396 if ((supported_modes >> DELL_COOL_BOTTOM) & 1)
2397 set_bit(PLATFORM_PROFILE_COOL, thermal_handler->choices);
2398 if ((supported_modes >> DELL_BALANCED) & 1)
2399 set_bit(PLATFORM_PROFILE_BALANCED, thermal_handler->choices);
2400 if ((supported_modes >> DELL_PERFORMANCE) & 1)
2401 set_bit(PLATFORM_PROFILE_PERFORMANCE, thermal_handler->choices);
2402
2403 // Clean up but do not fail
> 2404 if (platform_profile_register(thermal_handler))
2405 kfree(thermal_handler);
2406
2407 return 0;
2408 }
2409
2410 void thermal_cleanup(void)
2411 {
> 2412 platform_profile_remove();
2413 kfree(thermal_handler);
2414 }
2415
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
parent reply other threads:[~2024-05-13 20:09 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240426020448.10862-1-lsanche@lyndeno.ca>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405140348.Wz7gOmdP-lkp@intel.com \
--to=lkp@intel.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=W_Armin@gmx.de \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lsanche@lyndeno.ca \
--cc=mario.limonciello@amd.com \
--cc=mjg59@srcf.ucam.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).