From: kernel test robot <lkp@intel.com>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH RFC net-next 2/6] net: stmmac: remove pcs_ctrl_ane() method and associated code
Date: Mon, 13 May 2024 12:13:44 +0800 [thread overview]
Message-ID: <202405131156.MvTAH7ji-lkp@intel.com> (raw)
In-Reply-To: <E1s6C4O-00Ck6O-9D@rmk-PC.armlinux.org.uk>
Hi Russell,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Russell-King-Oracle/net-stmmac-remove-pcs_ctrl_ane-method-and-associated-code/20240513-003120
base: net-next/main
patch link: https://lore.kernel.org/r/E1s6C4O-00Ck6O-9D%40rmk-PC.armlinux.org.uk
patch subject: [PATCH RFC net-next 2/6] net: stmmac: remove pcs_ctrl_ane() method and associated code
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240513/202405131156.MvTAH7ji-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240513/202405131156.MvTAH7ji-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405131156.MvTAH7ji-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c: In function 'ethqos_configure_sgmii':
>> drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c:628:17: error: implicit declaration of function 'stmmac_pcs_ctrl_ane'; did you mean 'stmmac_pcs_rane'? [-Werror=implicit-function-declaration]
628 | stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 0, 0, 0);
| ^~~~~~~~~~~~~~~~~~~
| stmmac_pcs_rane
cc1: some warnings being treated as errors
vim +628 drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
a7c30e62d4b895 Vinod Koul 2019-01-21 607
981d947bcd382c Sneh Shah 2023-12-12 608 /* On interface toggle MAC registers gets reset.
981d947bcd382c Sneh Shah 2023-12-12 609 * Configure MAC block for SGMII on ethernet phy link up
981d947bcd382c Sneh Shah 2023-12-12 610 */
463120c31c58bb Bartosz Golaszewski 2023-06-19 611 static int ethqos_configure_sgmii(struct qcom_ethqos *ethqos)
463120c31c58bb Bartosz Golaszewski 2023-06-19 612 {
a818bd12538c14 Sneh Shah 2024-02-20 613 struct net_device *dev = platform_get_drvdata(ethqos->pdev);
a818bd12538c14 Sneh Shah 2024-02-20 614 struct stmmac_priv *priv = netdev_priv(dev);
463120c31c58bb Bartosz Golaszewski 2023-06-19 615 int val;
463120c31c58bb Bartosz Golaszewski 2023-06-19 616
463120c31c58bb Bartosz Golaszewski 2023-06-19 617 val = readl(ethqos->mac_base + MAC_CTRL_REG);
463120c31c58bb Bartosz Golaszewski 2023-06-19 618
463120c31c58bb Bartosz Golaszewski 2023-06-19 619 switch (ethqos->speed) {
a818bd12538c14 Sneh Shah 2024-02-20 620 case SPEED_2500:
a818bd12538c14 Sneh Shah 2024-02-20 621 val &= ~ETHQOS_MAC_CTRL_PORT_SEL;
a818bd12538c14 Sneh Shah 2024-02-20 622 rgmii_updatel(ethqos, RGMII_CONFIG2_RGMII_CLK_SEL_CFG,
a818bd12538c14 Sneh Shah 2024-02-20 623 RGMII_CONFIG2_RGMII_CLK_SEL_CFG,
a818bd12538c14 Sneh Shah 2024-02-20 624 RGMII_IO_MACRO_CONFIG2);
a818bd12538c14 Sneh Shah 2024-02-20 625 if (ethqos->serdes_speed != SPEED_2500)
a818bd12538c14 Sneh Shah 2024-02-20 626 phy_set_speed(ethqos->serdes_phy, SPEED_2500);
a818bd12538c14 Sneh Shah 2024-02-20 627 ethqos->serdes_speed = SPEED_2500;
a818bd12538c14 Sneh Shah 2024-02-20 @628 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 0, 0, 0);
a818bd12538c14 Sneh Shah 2024-02-20 629 break;
463120c31c58bb Bartosz Golaszewski 2023-06-19 630 case SPEED_1000:
463120c31c58bb Bartosz Golaszewski 2023-06-19 631 val &= ~ETHQOS_MAC_CTRL_PORT_SEL;
463120c31c58bb Bartosz Golaszewski 2023-06-19 632 rgmii_updatel(ethqos, RGMII_CONFIG2_RGMII_CLK_SEL_CFG,
463120c31c58bb Bartosz Golaszewski 2023-06-19 633 RGMII_CONFIG2_RGMII_CLK_SEL_CFG,
463120c31c58bb Bartosz Golaszewski 2023-06-19 634 RGMII_IO_MACRO_CONFIG2);
a818bd12538c14 Sneh Shah 2024-02-20 635 if (ethqos->serdes_speed != SPEED_1000)
a818bd12538c14 Sneh Shah 2024-02-20 636 phy_set_speed(ethqos->serdes_phy, SPEED_1000);
a818bd12538c14 Sneh Shah 2024-02-20 637 ethqos->serdes_speed = SPEED_1000;
a818bd12538c14 Sneh Shah 2024-02-20 638 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, 0, 0);
463120c31c58bb Bartosz Golaszewski 2023-06-19 639 break;
463120c31c58bb Bartosz Golaszewski 2023-06-19 640 case SPEED_100:
463120c31c58bb Bartosz Golaszewski 2023-06-19 641 val |= ETHQOS_MAC_CTRL_PORT_SEL | ETHQOS_MAC_CTRL_SPEED_MODE;
a818bd12538c14 Sneh Shah 2024-02-20 642 if (ethqos->serdes_speed != SPEED_1000)
a818bd12538c14 Sneh Shah 2024-02-20 643 phy_set_speed(ethqos->serdes_phy, SPEED_1000);
a818bd12538c14 Sneh Shah 2024-02-20 644 ethqos->serdes_speed = SPEED_1000;
a818bd12538c14 Sneh Shah 2024-02-20 645 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, 0, 0);
463120c31c58bb Bartosz Golaszewski 2023-06-19 646 break;
463120c31c58bb Bartosz Golaszewski 2023-06-19 647 case SPEED_10:
463120c31c58bb Bartosz Golaszewski 2023-06-19 648 val |= ETHQOS_MAC_CTRL_PORT_SEL;
463120c31c58bb Bartosz Golaszewski 2023-06-19 649 val &= ~ETHQOS_MAC_CTRL_SPEED_MODE;
981d947bcd382c Sneh Shah 2023-12-12 650 rgmii_updatel(ethqos, RGMII_CONFIG_SGMII_CLK_DVDR,
981d947bcd382c Sneh Shah 2023-12-12 651 FIELD_PREP(RGMII_CONFIG_SGMII_CLK_DVDR,
981d947bcd382c Sneh Shah 2023-12-12 652 SGMII_10M_RX_CLK_DVDR),
981d947bcd382c Sneh Shah 2023-12-12 653 RGMII_IO_MACRO_CONFIG);
a818bd12538c14 Sneh Shah 2024-02-20 654 if (ethqos->serdes_speed != SPEED_1000)
a818bd12538c14 Sneh Shah 2024-02-20 655 phy_set_speed(ethqos->serdes_phy, ethqos->speed);
a818bd12538c14 Sneh Shah 2024-02-20 656 ethqos->serdes_speed = SPEED_1000;
a818bd12538c14 Sneh Shah 2024-02-20 657 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, 0, 0);
463120c31c58bb Bartosz Golaszewski 2023-06-19 658 break;
463120c31c58bb Bartosz Golaszewski 2023-06-19 659 }
463120c31c58bb Bartosz Golaszewski 2023-06-19 660
463120c31c58bb Bartosz Golaszewski 2023-06-19 661 writel(val, ethqos->mac_base + MAC_CTRL_REG);
463120c31c58bb Bartosz Golaszewski 2023-06-19 662
463120c31c58bb Bartosz Golaszewski 2023-06-19 663 return val;
463120c31c58bb Bartosz Golaszewski 2023-06-19 664 }
463120c31c58bb Bartosz Golaszewski 2023-06-19 665
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next parent reply other threads:[~2024-05-13 4:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1s6C4O-00Ck6O-9D@rmk-PC.armlinux.org.uk>
2024-05-13 4:13 ` kernel test robot [this message]
2024-05-13 5:15 ` [PATCH RFC net-next 2/6] net: stmmac: remove pcs_ctrl_ane() method and associated code kernel test robot
2024-05-25 4:13 ` kernel test robot
2024-05-25 4:24 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405131156.MvTAH7ji-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).