From: Jonathan Cameron <jic23@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: Ramona Gradinariu <ramona.bolboaca13@gmail.com>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, conor+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh@kernel.org,
nuno.sa@analog.com, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v2 4/8] iio: imu: adis_buffer: Add buffer setup API with buffer attributes
Date: Sat, 11 May 2024 14:22:52 +0100 [thread overview]
Message-ID: <20240511142252.4c3b11f0@jic23-huawei> (raw)
In-Reply-To: <202405110642.5PmTepVs-lkp@intel.com>
On Sat, 11 May 2024 06:21:53 +0800
kernel test robot <lkp@intel.com> wrote:
> Hi Ramona,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on jic23-iio/togreg]
> [also build test WARNING on linus/master v6.9-rc7 next-20240510]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Ramona-Gradinariu/dt-bindings-iio-imu-Add-ADIS16501-compatibles/20240508-211559
> base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> patch link: https://lore.kernel.org/r/20240508131310.880479-5-ramona.bolboaca13%40gmail.com
> patch subject: [PATCH v2 4/8] iio: imu: adis_buffer: Add buffer setup API with buffer attributes
> config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240511/202405110642.5PmTepVs-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240511/202405110642.5PmTepVs-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202405110642.5PmTepVs-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> In file included from drivers/iio/imu/adis16400.c:24:
> >> include/linux/iio/imu/adis.h:530:60: warning: 'struct iio_dev_attr' declared inside parameter list will not be visible outside of this definition or declaration
> 530 | const struct iio_dev_attr **buffer_attrs);
> | ^~~~~~~~~~~~
>
>
> vim +530 include/linux/iio/imu/adis.h
>
> 524
> 525 int
> 526 devm_adis_setup_buffer_and_trigger_with_attrs(struct adis *adis,
> 527 struct iio_dev *indio_dev,
> 528 irq_handler_t trigger_handler,
> 529 const struct iio_buffer_setup_ops *ops,
> > 530 const struct iio_dev_attr **buffer_attrs);
> 531
>
Forwards declaration needed. I don't think we'd want to include linux/iio/sysfs.h in here so
struct iio_dev_attr; before this is the cleanest solution
Jonathan
prev parent reply other threads:[~2024-05-11 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240508131310.880479-5-ramona.bolboaca13@gmail.com>
2024-05-10 22:21 ` [PATCH v2 4/8] iio: imu: adis_buffer: Add buffer setup API with buffer attributes kernel test robot
2024-05-11 13:22 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240511142252.4c3b11f0@jic23-huawei \
--to=jic23@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nuno.sa@analog.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ramona.bolboaca13@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).