From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Su Yue <glass.su@suse.com>, akpm <akpm@linux-foundation.org>
Cc: ocfs2-devel@lists.linux.dev
Subject: Re: [PATCH] ocfs2: update inode ctime in ocfs2_fileattr_set
Date: Tue, 19 Mar 2024 09:43:04 +0800 [thread overview]
Message-ID: <e1d44e5a-aae4-4331-a276-2f71b64f2198@linux.alibaba.com> (raw)
In-Reply-To: <20240318115609.3194-1-l@damenly.org>
On 3/18/24 7:56 PM, Su Yue wrote:
> From: Su Yue <glass.su@suse.com>
>
> inode ctime should be updated if ocfs2_fileattr_set is called.
>
> Signed-off-by: Su Yue <glass.su@suse.com>
Looks fine.
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/ioctl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c
> index b1550ba73f96..71beef7f8a60 100644
> --- a/fs/ocfs2/ioctl.c
> +++ b/fs/ocfs2/ioctl.c
> @@ -125,6 +125,7 @@ int ocfs2_fileattr_set(struct mnt_idmap *idmap,
>
> ocfs2_inode->ip_attr = flags;
> ocfs2_set_inode_flags(inode);
> + inode_set_ctime_current(inode);
>
> status = ocfs2_mark_inode_dirty(handle, inode, bh);
> if (status < 0)
prev parent reply other threads:[~2024-03-19 1:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 11:56 [PATCH] ocfs2: update inode ctime in ocfs2_fileattr_set Su Yue
2024-03-19 1:43 ` Joseph Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1d44e5a-aae4-4331-a276-2f71b64f2198@linux.alibaba.com \
--to=joseph.qi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=glass.su@suse.com \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).