From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Chengming Zhou <chengming.zhou@linux.dev>,
mark@fasheh.com, jlbec@evilplan.org, brauner@kernel.org,
jlayton@kernel.org, keescook@chromium.org,
akpm <akpm@linux-foundation.org>
Cc: jack@suse.cz, zhouchengming@bytedance.com,
azeemshaikh38@gmail.com, ocfs2-devel@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz,
roman.gushchin@linux.dev, Xiongwei.Song@windriver.com
Subject: Re: [PATCH] ocfs2: remove SLAB_MEM_SPREAD flag usage
Date: Mon, 26 Feb 2024 09:11:09 +0800 [thread overview]
Message-ID: <d34ba82f-cde8-4bf9-ab97-a1c4c06c2972@linux.alibaba.com> (raw)
In-Reply-To: <34678776-859a-42f2-802b-0c7bc90bdfdc@linux.dev>
On 2/25/24 9:02 PM, Chengming Zhou wrote:
> On 2024/2/25 20:20, Joseph Qi wrote:
>>
>>
>> On 2/24/24 9:50 PM, chengming.zhou@linux.dev wrote:
>>> From: Chengming Zhou <zhouchengming@bytedance.com>
>>>
>>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
>>> its usage so we can delete it from slab. No functional change.
>>>
>> If I understand correctly, you are referring the following patch:
>> https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
>>
>> But it seems that the above patch is not included in mainline yet.
>> Or am I missing something?
>
> I realize my commit message should explain more why it's a no-op, my bad.
>
> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
> removed so it became a dead flag as of v6.8-rc1. That series[1]
> mark it obsolete to avoid confusion for users. So here we can just
> remove all its users, which has no functional changes.
>
> [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
>
Take more look at v6.8-rc1, I've found the following commit:
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h")
It seems that after this commit, there is no user of 'SLAB_MEM_SPREAD'. So,
Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
prev parent reply other threads:[~2024-02-26 1:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 13:50 [PATCH] ocfs2: remove SLAB_MEM_SPREAD flag usage chengming.zhou
2024-02-25 12:20 ` Joseph Qi
2024-02-25 13:02 ` Chengming Zhou
2024-02-26 1:11 ` Joseph Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d34ba82f-cde8-4bf9-ab97-a1c4c06c2972@linux.alibaba.com \
--to=joseph.qi@linux.alibaba.com \
--cc=Xiongwei.Song@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=azeemshaikh38@gmail.com \
--cc=brauner@kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).