From: Heming Zhao <heming.zhao@suse.com>
To: Colin Ian King <colin.i.king@gmail.com>,
Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: kernel-janitors@vger.kernel.org, ocfs2-devel@lists.linux.dev
Subject: Re: [PATCH][next] ocfs2: remove redundant assignment to variable status
Date: Wed, 24 Apr 2024 09:40:33 +0800 [thread overview]
Message-ID: <8e22e6d4-4c62-4b78-9809-5648537af775@suse.com> (raw)
In-Reply-To: <20240423223018.1573213-1-colin.i.king@gmail.com>
On 4/24/24 06:30, Colin Ian King wrote:
> Variable status is being assigned and error code that is never read, it is
> being assigned inside of a do-while loop. The assignment is redundant and
> can be removed.
>
> Cleans up clang scan build warning:
> fs/ocfs2/dlm/dlmdomain.c:1530:2: warning: Value stored to 'status' is never
> read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> fs/ocfs2/dlm/dlmdomain.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ocfs2/dlm/dlmdomain.c b/fs/ocfs2/dlm/dlmdomain.c
> index 2e0a2f338282..2018501b2249 100644
> --- a/fs/ocfs2/dlm/dlmdomain.c
> +++ b/fs/ocfs2/dlm/dlmdomain.c
> @@ -1527,7 +1527,6 @@ static void dlm_send_join_asserts(struct dlm_ctxt *dlm,
> {
> int status, node, live;
>
> - status = 0;
> node = -1;
> while ((node = find_next_bit(node_map, O2NM_MAX_NODES,
> node + 1)) < O2NM_MAX_NODES) {
This mail cc linux-kernel@vger.kernel.org, it would be better to only
cc ocfs2-devel next time.
This patch is correct, but it's a very trivial fix. I am not sure if
Joseph is willing to take time to push to mainline kernel.
Thanks,
Heming
next prev parent reply other threads:[~2024-04-24 1:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 22:30 [PATCH][next] ocfs2: remove redundant assignment to variable status Colin Ian King
2024-04-24 1:40 ` Heming Zhao [this message]
2024-04-24 5:54 ` Dan Carpenter
2024-04-24 3:30 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e22e6d4-4c62-4b78-9809-5648537af775@suse.com \
--to=heming.zhao@suse.com \
--cc=colin.i.king@gmail.com \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).