From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Artem Chernyshev <artem.chernyshev@red-soft.ru>,
Joel Becker <jlbec@evilplan.org>, Mark Fasheh <mark@fasheh.com>,
akpm <akpm@linux-foundation.org>
Cc: Kurt Hackel <kurt.hackel@oracle.com>,
ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] fs: ocfs2: namei: Check return value of ocfs2_add_entry()
Date: Fri, 4 Aug 2023 09:23:06 +0800 [thread overview]
Message-ID: <2c123597-e8bd-a0a0-cfb1-2236aa035870@linux.alibaba.com> (raw)
In-Reply-To: <20230803145417.177649-1-artem.chernyshev@red-soft.ru>
On 8/3/23 10:54 PM, Artem Chernyshev wrote:
> Process result of ocfs2_add_entry() in case we have an error
> value.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: ccd979bdbce9 ("[PATCH] OCFS2: The Second Oracle Cluster Filesystem")
> Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/namei.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index 17c52225b87d..03bccfd183f3 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -1535,6 +1535,10 @@ static int ocfs2_rename(struct mnt_idmap *idmap,
> status = ocfs2_add_entry(handle, new_dentry, old_inode,
> OCFS2_I(old_inode)->ip_blkno,
> new_dir_bh, &target_insert);
> + if (status < 0) {
> + mlog_errno(status);
> + goto bail;
> + }
> }
>
> old_inode->i_ctime = current_time(old_inode);
prev parent reply other threads:[~2023-08-04 1:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 14:54 [PATCH] fs: ocfs2: namei: Check return value of ocfs2_add_entry() Artem Chernyshev
2023-08-04 1:23 ` Joseph Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c123597-e8bd-a0a0-cfb1-2236aa035870@linux.alibaba.com \
--to=joseph.qi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=artem.chernyshev@red-soft.ru \
--cc=jlbec@evilplan.org \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).