From: Azeem Shaikh <azeemshaikh38@gmail.com>
To: Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: linux-hardening@vger.kernel.org,
Azeem Shaikh <azeemshaikh38@gmail.com>,
ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
Dave Chinner <dchinner@redhat.com>,
Jeff Layton <jlayton@kernel.org>
Subject: [PATCH 0/2] ocfs2: Replace strlcpy with strscpy
Date: Wed, 30 Aug 2023 21:54:24 +0000 [thread overview]
Message-ID: <20230830215426.4181755-1-azeemshaikh38@gmail.com> (raw)
Hi,
The main patch this series is targeting is [PATCH 2] which replaces
strlcpy() call with strscpy(). However, while I was tinkering through
the code I noticed that `module_param_call` is marked obsolete and
`module_param_cb` is preferred instead. So I have included [PATCH 1]
which does that.
A crucial thing in [PATCH 2] I would like to bring to reviewer's
attention is that it changes behavior for the case where
sizeof(@buffer) < DLMFS_CAPABILITIES. Currently, this is silently ignored
but with the current change it returns -errno.
Thanks,
Azeem
Azeem Shaikh (2):
Replace module_param_call with module_param_cb
Replace strlcpy with strscpy
fs/ocfs2/dlmfs/dlmfs.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
--
2.42.0.283.g2d96d420d3-goog
next reply other threads:[~2023-08-30 21:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 21:54 Azeem Shaikh [this message]
2023-08-30 21:54 ` [PATCH 1/2] ocfs2: Replace module_param_call with module_param_cb Azeem Shaikh
2023-08-30 23:00 ` Kees Cook
2023-08-30 21:54 ` [PATCH 2/2] ocfs2: Replace strlcpy with strscpy Azeem Shaikh
2023-08-30 22:17 ` Justin Stitt
2023-08-30 23:06 ` Kees Cook
2023-08-31 19:28 ` Azeem Shaikh
2023-08-31 21:04 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230830215426.4181755-1-azeemshaikh38@gmail.com \
--to=azeemshaikh38@gmail.com \
--cc=brauner@kernel.org \
--cc=dchinner@redhat.com \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).