Re: [Ocfs2-devel] [PATCH v3 2/6] erofs: convert to use i_blockmask() - Al Viro via Ocfs2-devel

From: Al Viro via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: Yangtao Li <frank.li@vivo.com>
Cc: brauner@kernel.org, tytso@mit.edu, agruenba@redhat.com,
	chao@kernel.org, linux-kernel@vger.kernel.org,
	cluster-devel@redhat.com, rpeterso@redhat.com,
	huyue2@coolpad.com, adilger.kernel@dilger.ca,
	jefflexu@linux.alibaba.com, linux-fsdevel@vger.kernel.org,
	xiang@kernel.org, linux-ext4@vger.kernel.org,
	linux-erofs@lists.ozlabs.org, ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [PATCH v3 2/6] erofs: convert to use i_blockmask()
Date: Fri, 10 Mar 2023 03:15:47 +0000	[thread overview]
Message-ID: <20230310031547.GD3390869@ZenIV> (raw)
In-Reply-To: <20230309152127.41427-2-frank.li@vivo.com>

On Thu, Mar 09, 2023 at 11:21:23PM +0800, Yangtao Li wrote:
> Use i_blockmask() to simplify code.

Umm...  What's the branchpoint for that series?  Not the mainline -
there we have i_blocksize() open-coded...

> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> v3:
> -none
> v2:
> -convert to i_blockmask()
>  fs/erofs/data.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/erofs/data.c b/fs/erofs/data.c
> index 7e8baf56faa5..e9d1869cd4b3 100644
> --- a/fs/erofs/data.c
> +++ b/fs/erofs/data.c
> @@ -380,7 +380,7 @@ static ssize_t erofs_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
>  		if (bdev)
>  			blksize_mask = bdev_logical_block_size(bdev) - 1;
>  		else
> -			blksize_mask = i_blocksize(inode) - 1;
> +			blksize_mask = i_blockmask(inode);
>  
>  		if ((iocb->ki_pos | iov_iter_count(to) |
>  		     iov_iter_alignment(to)) & blksize_mask)
> -- 
> 2.25.1
> 

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel