From: Christian Brauner via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: Yangtao Li <frank.li@vivo.com>
Cc: tytso@mit.edu, agruenba@redhat.com, chao@kernel.org,
linux-kernel@vger.kernel.org, cluster-devel@redhat.com,
rpeterso@redhat.com, huyue2@coolpad.com,
adilger.kernel@dilger.ca, jefflexu@linux.alibaba.com,
linux-fsdevel@vger.kernel.org, xiang@kernel.org,
linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org,
ocfs2-devel@oss.oracle.com, viro@zeniv.linux.org.uk
Subject: Re: [Ocfs2-devel] [PATCH v2 1/5] fs: add i_blockmask()
Date: Thu, 9 Mar 2023 15:58:38 +0100 [thread overview]
Message-ID: <20230309145838.pgkkkhp4ahvqdkv5@wittgenstein> (raw)
In-Reply-To: <20230309124035.15820-1-frank.li@vivo.com>
On Thu, Mar 09, 2023 at 08:40:31PM +0800, Yangtao Li wrote:
> Introduce i_blockmask() to simplify code, which replace
> (i_blocksize(node) - 1). Like done in commit
> 93407472a21b("fs: add i_blocksize()").
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
Looks good but did you forget to convert fs/remap_range.c by any chance?
static int generic_remap_check_len(struct inode *inode_in,
struct inode *inode_out,
loff_t pos_out,
loff_t *len,
unsigned int remap_flags)
{
u64 blkmask = i_blocksize(inode_in) - 1;
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
prev parent reply other threads:[~2023-03-09 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 12:40 [Ocfs2-devel] [PATCH v2 1/5] fs: add i_blockmask() Yangtao Li via Ocfs2-devel
2023-03-09 12:40 ` [Ocfs2-devel] [PATCH v2 2/5] erofs: convert to use i_blockmask() Yangtao Li via Ocfs2-devel
2023-03-09 12:40 ` [Ocfs2-devel] [PATCH v2 3/5] gfs2: " Yangtao Li via Ocfs2-devel
2023-03-09 12:40 ` [Ocfs2-devel] [PATCH v2 4/5] ext4: " Yangtao Li via Ocfs2-devel
2023-03-09 12:40 ` [Ocfs2-devel] [PATCH v2 5/5] ocfs2: " Yangtao Li via Ocfs2-devel
2023-03-09 14:58 ` Christian Brauner via Ocfs2-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309145838.pgkkkhp4ahvqdkv5@wittgenstein \
--to=ocfs2-devel@oss.oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=agruenba@redhat.com \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=cluster-devel@redhat.com \
--cc=frank.li@vivo.com \
--cc=huyue2@coolpad.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpeterso@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).