From: Joseph Qi via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: "Luís Henriques" <lhenriques@suse.de>,
"Heming Zhao" <heming.zhao@suse.com>
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [PATCH] ocfs2: fix use-after-free when unmounting read-only filesystem
Date: Tue, 23 May 2023 10:43:11 +0800 [thread overview]
Message-ID: <002ed0eb-1195-ce7e-06a0-d85155f67f04@linux.alibaba.com> (raw)
In-Reply-To: <87cz2s7b6m.fsf@brahms.olymp>
On 5/22/23 9:22 PM, Luís Henriques wrote:
> Heming Zhao <heming.zhao@suse.com> writes:
>
>> On Mon, May 22, 2023 at 01:23:07PM +0100, Luís Henriques wrote:
>>> Joseph Qi <joseph.qi@linux.alibaba.com> writes:
>>>
>>>> On 5/22/23 6:25 PM, Luís Henriques wrote:
>>>>> It's trivial to trigger a use-after-free bug in the ocfs2 quotas code using
>>>>> fstest generic/452. After mounting a filesystem as read-only, quotas are
>>>>
>>>> generic/452 is for testing ext4 mounted with dax and ro.
>>>> But ocfs2 doesn't support dax yet.
>>>
>>> Right, but I think it's still useful to run the 'generic' test-suite in a
>>> filesystem. We can always find issues in the test itself or, in this
>>> case, a bug in the filesystem.
>>
>> It looks you did some special steps for 452. In my env, without changing
>> anything, I could pass this case successfully.
>
> No, I haven't changed anything to the test. I just make sure there's a
> scratch device to be used.
>
> Maybe you can try to enable KASAN to catch the UAF. I've found the bug
> without KASAN (i.e. I saw a NULL pointer panic), but enabling it also
> detects the issue -- see below.
>
> Cheers,
We'd better append panic dmesg to patch description as well.
Thanks,
Joseph
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
next prev parent reply other threads:[~2023-05-23 2:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 10:25 [Ocfs2-devel] [PATCH] ocfs2: fix use-after-free when unmounting read-only filesystem Luís Henriques via Ocfs2-devel
2023-05-22 12:01 ` Joseph Qi via Ocfs2-devel
2023-05-22 12:23 ` Luís Henriques via Ocfs2-devel
2023-05-22 12:36 ` Heming Zhao via Ocfs2-devel
2023-05-22 13:22 ` Luís Henriques via Ocfs2-devel
2023-05-23 2:43 ` Joseph Qi via Ocfs2-devel [this message]
2023-05-23 2:41 ` Joseph Qi via Ocfs2-devel
-- strict thread matches above, loose matches on Subject: below --
2023-05-22 10:24 Luís Henriques via Ocfs2-devel
2023-05-22 10:21 Luís Henriques via Ocfs2-devel
2023-05-22 10:20 Luís Henriques via Ocfs2-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=002ed0eb-1195-ce7e-06a0-d85155f67f04@linux.alibaba.com \
--to=ocfs2-devel@oss.oracle.com \
--cc=heming.zhao@suse.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=lhenriques@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).