From: Dave Jiang <dave.jiang@intel.com>
To: Dan Williams <dan.j.williams@intel.com>,
Xiao Yang <yangx.jy@fujitsu.com>, <vishal.l.verma@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <nvdimm@lists.linux.dev>,
"lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
<caoqq@fujitsu.com>
Subject: Re: [NDCTL PATCH v2] cxl/region: Add -f option for disable-region
Date: Mon, 30 Oct 2023 14:30:07 -0700 [thread overview]
Message-ID: <d455eea4-6460-45e8-bcf9-7fab970da163@intel.com> (raw)
In-Reply-To: <653ff6862f08a_244c782945@dwillia2-xfh.jf.intel.com.notmuch>
On 10/30/23 11:31, Dan Williams wrote:
> Dave Jiang wrote:
> [..]
>> Ah that was a mistake. I meant to call the query function and not the
>> online op function. Do you have any objections to
>>
>> if (!daxctl_memory_is_movable(mem))
>
> Wait, why check for movable? ZONE_NORMAL can be removed if you are
> lucky, and ZONE_MOVABLE may still not be able to be removed if you are
> unlucky. So I would expect that disable-region attempts to offline
> all-memory blocks, and if that fails then fail the disable-region. That
> would of course need to come with documentation that disable-region may
> leave the memory in a partially offline state. Then the force can just
> rip the device away with the warning message that physical address space
> has now been permanently leaked and can not be recovered until a reboot.
I'll update as you outlined above.
prev parent reply other threads:[~2023-10-30 21:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 22:57 [NDCTL PATCH v2] cxl/region: Add -f option for disable-region Dave Jiang
2023-09-21 2:58 ` Zhijian Li (Fujitsu)
2023-09-21 23:19 ` Dave Jiang
2023-09-22 1:26 ` Zhijian Li (Fujitsu)
2023-10-09 10:52 ` Xiao Yang
2023-10-13 22:38 ` Dave Jiang
2023-10-30 4:33 ` Xiao Yang
2023-10-30 16:24 ` Dave Jiang
2023-10-30 18:31 ` Dan Williams
2023-10-30 21:30 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d455eea4-6460-45e8-bcf9-7fab970da163@intel.com \
--to=dave.jiang@intel.com \
--cc=caoqq@fujitsu.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
--cc=yangx.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).