From: alison.schofield@intel.com
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Subject: [ndctl PATCH v4 5/5] cxl/test: add cxl-poison.sh unit test
Date: Tue, 21 Nov 2023 10:58:51 -0800 [thread overview]
Message-ID: <6ca73fd15229c3e1d8d200bf87bc22edbe554114.1700591754.git.alison.schofield@intel.com> (raw)
In-Reply-To: <cover.1700591754.git.alison.schofield@intel.com>
From: Alison Schofield <alison.schofield@intel.com>
Exercise cxl list, libcxl, and driver pieces of the get poison list
pathway. Inject and clear poison using debugfs and use cxl-cli to
read the poison list by memdev and by region.
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
test/cxl-poison.sh | 154 +++++++++++++++++++++++++++++++++++++++++++++
test/meson.build | 2 +
2 files changed, 156 insertions(+)
create mode 100644 test/cxl-poison.sh
diff --git a/test/cxl-poison.sh b/test/cxl-poison.sh
new file mode 100644
index 000000000000..0512c4c742e8
--- /dev/null
+++ b/test/cxl-poison.sh
@@ -0,0 +1,154 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (C) 2022 Intel Corporation. All rights reserved.
+
+. "$(dirname "$0")"/common
+
+rc=77
+
+set -ex
+
+trap 'err $LINENO' ERR
+
+check_prereq "jq"
+
+modprobe -r cxl_test
+modprobe cxl_test
+
+rc=1
+
+# THEORY OF OPERATION: Exercise cxl-cli and cxl driver ability to
+# inject, clear, and get the poison list. Do it by memdev and by region.
+# Based on current cxl-test topology.
+
+find_memdev()
+{
+ readarray -t capable_mems < <("$CXL" list -b "$CXL_TEST_BUS" -M |
+ jq -r ".[] | select(.pmem_size != null) |
+ select(.ram_size != null) | .memdev")
+
+ if [ ${#capable_mems[@]} == 0 ]; then
+ echo "no memdevs found for test"
+ err "$LINENO"
+ fi
+
+ memdev=${capable_mems[0]}
+}
+
+setup_x2_region()
+{
+ # Find an x2 decoder
+ decoder=$($CXL list -b "$CXL_TEST_BUS" -D -d root | jq -r ".[] |
+ select(.pmem_capable == true) |
+ select(.nr_targets == 2) |
+ .decoder")
+
+ # Find a memdev for each host-bridge interleave position
+ port_dev0=$($CXL list -T -d "$decoder" | jq -r ".[] |
+ .targets | .[] | select(.position == 0) | .target")
+ port_dev1=$($CXL list -T -d "$decoder" | jq -r ".[] |
+ .targets | .[] | select(.position == 1) | .target")
+ mem0=$($CXL list -M -p "$port_dev0" | jq -r ".[0].memdev")
+ mem1=$($CXL list -M -p "$port_dev1" | jq -r ".[0].memdev")
+ memdevs="$mem0 $mem1"
+}
+
+create_region()
+{
+ setup_x2_region
+ region=$($CXL create-region -d "$decoder" -m "$memdevs" |
+ jq -r ".region")
+ if [[ ! $region ]]; then
+ echo "create-region failed for $decoder"
+ err "$LINENO"
+ fi
+}
+
+# When cxl-cli support for inject and clear arrives, replace
+# the writes to /sys/kernel/debug with the new cxl commands.
+
+inject_poison_sysfs()
+{
+ memdev="$1"
+ addr="$2"
+
+ echo "$addr" > /sys/kernel/debug/cxl/"$memdev"/inject_poison
+}
+
+clear_poison_sysfs()
+{
+ memdev="$1"
+ addr="$2"
+
+ echo "$addr" > /sys/kernel/debug/cxl/"$memdev"/clear_poison
+}
+
+validate_region()
+{
+ poison_list="$1"
+ region_expect="$2"
+
+ # Make sure region name format stays sane
+ region_found="$(jq -r ".records | .[0] | .region" <<< "$poison_list")"
+ if [[ "$region_found" != "$region_expect" ]]; then
+ echo "$region_expect expected, $region_found found"
+ err "$LINENO"
+ fi
+}
+
+validate_nr_records()
+{
+ poison_list="$1"
+ nr_expect="$2"
+
+ nr_found="$(jq -r ".nr_records" <<< "$poison_list")"
+ if [ "$nr_found" -ne "$nr_expect" ]; then
+ echo "$nr_expect poison records expected, $nr_found found"
+ err "$LINENO"
+ fi
+}
+
+test_poison_by_memdev()
+{
+ find_memdev
+ inject_poison_sysfs "$memdev" "0x40000000"
+ inject_poison_sysfs "$memdev" "0x40001000"
+ inject_poison_sysfs "$memdev" "0x600"
+ inject_poison_sysfs "$memdev" "0x0"
+ json=$("$CXL" list -m "$memdev" --poison | jq -r '.[].poison')
+ validate_nr_records "$json" 4
+
+ clear_poison_sysfs "$memdev" "0x40000000"
+ clear_poison_sysfs "$memdev" "0x40001000"
+ clear_poison_sysfs "$memdev" "0x600"
+ clear_poison_sysfs "$memdev" "0x0"
+ json=$("$CXL" list -m "$memdev" --poison | jq -r '.[].poison')
+ validate_nr_records "$json" 0
+}
+
+test_poison_by_region()
+{
+ create_region
+ inject_poison_sysfs "$mem0" "0x40000000"
+ inject_poison_sysfs "$mem1" "0x40000000"
+ json=$("$CXL" list -r "$region" --poison | jq -r '.[].poison')
+ validate_nr_records "$json" 2
+ validate_region "$json" "$region"
+
+ clear_poison_sysfs "$mem0" "0x40000000"
+ clear_poison_sysfs "$mem1" "0x40000000"
+ json=$("$CXL" list -r "$region" --poison | jq -r '.[].poison')
+ validate_nr_records "$json" 0
+}
+
+# Turn tracing on. Note that 'cxl list --poison' does toggle the tracing.
+# Turning it on here allows the test user to also view inject and clear
+# trace events.
+echo 1 > /sys/kernel/tracing/events/cxl/cxl_poison/enable
+
+test_poison_by_memdev
+test_poison_by_region
+
+check_dmesg "$LINENO"
+
+modprobe -r cxl-test
diff --git a/test/meson.build b/test/meson.build
index 224adaf41fcc..2706fa5d633c 100644
--- a/test/meson.build
+++ b/test/meson.build
@@ -157,6 +157,7 @@ cxl_create_region = find_program('cxl-create-region.sh')
cxl_xor_region = find_program('cxl-xor-region.sh')
cxl_update_firmware = find_program('cxl-update-firmware.sh')
cxl_events = find_program('cxl-events.sh')
+cxl_poison = find_program('cxl-poison.sh')
tests = [
[ 'libndctl', libndctl, 'ndctl' ],
@@ -186,6 +187,7 @@ tests = [
[ 'cxl-create-region.sh', cxl_create_region, 'cxl' ],
[ 'cxl-xor-region.sh', cxl_xor_region, 'cxl' ],
[ 'cxl-events.sh', cxl_events, 'cxl' ],
+ [ 'cxl-poison.sh', cxl_poison, 'cxl' ],
]
if get_option('destructive').enabled()
--
2.37.3
prev parent reply other threads:[~2023-11-21 18:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 18:58 [ndctl PATCH v4 0/5] Support poison list retrieval alison.schofield
2023-11-21 18:58 ` [ndctl PATCH v4 1/5] libcxl: add interfaces for GET_POISON_LIST mailbox commands alison.schofield
2023-11-21 18:58 ` [ndctl PATCH v4 2/5] cxl: add an optional pid check to event parsing alison.schofield
2023-11-21 18:58 ` [ndctl PATCH v4 3/5] cxl/list: collect and parse the poison list records alison.schofield
2023-11-21 18:58 ` [ndctl PATCH v4 4/5] cxl/list: add --poison option to cxl list alison.schofield
2023-11-21 18:58 ` alison.schofield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ca73fd15229c3e1d8d200bf87bc22edbe554114.1700591754.git.alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).