From: Michal Wilczynski <michal.wilczynski@intel.com>
To: linux-acpi@vger.kernel.org
Cc: rafael@kernel.org, dan.j.williams@intel.com,
vishal.l.verma@intel.com, lenb@kernel.org, dave.jiang@intel.com,
ira.weiny@intel.com, rui.zhang@intel.com,
linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev,
Michal Wilczynski <michal.wilczynski@intel.com>
Subject: [PATCH v3 0/6] Replace acpi_driver with platform_driver
Date: Wed, 11 Oct 2023 11:33:28 +0300 [thread overview]
Message-ID: <20231011083334.3987477-1-michal.wilczynski@intel.com> (raw)
Currently there is a number of drivers that somewhat incorrectly
register themselves as acpi_driver, while they should be registering as
platform_drivers. acpi_device was never meant to represent actual
device, it only represents an entry in the ACPI table and ACPI driver
should be treated as a driver for the ACPI entry of the particular
device, not the device itself. Drivers of the devices itself should
register as platform_drivers. Replace acpi_driver with platform_driver
for all relevant drivers in drivers/acpi directory. This is just the
first part of the change, as many acpi_drivers are present in many files
outside of drivers/acpi directory.
Additionally during internal review we've decided that it's best to send
the relevant patches sequentially, in order not to overwhelm the reviewers.
So I'm starting with NFIT and AC drivers.
This change is possible thanks to recent .notify callback removal in
drivers/acpi [1]. So flow for the remaining acpi_drivers will look like
this:
1) Remove .notify callback with separate patchset for drivers/platform
and other outstanding places like drivers/hwmon, drivers/iio etc.
2) Replace acpi_driver with platform_driver, as aside for .notify
callback they're mostly functionally compatible.
Most of the patches in this series could be considered independent, and
could be merged separately, with a notable exception of the very first
patch in this series that changes notify installer wrappers to be more
generic. I decided it would be best not to force the user of this
wrappers to pass any specific structure, like acpi_device or
platform_device. It makes sense as it is very often the case that
drivers declare their own private structure which gets allocated during
the .probe() callback, and become the heart of the driver. In that case
it makes much more sense to pass this structure to notify handler.
Additionally some drivers, like acpi_video that already have custom
notify handlers do that already.
Link: https://lore.kernel.org/linux-acpi/20230703080252.2899090-1-michal.wilczynski@intel.com/ [1]
v3:
- in AC transformation patch replaced struct device* with
struct acpi_device*, as suggested.
v2:
- dropped first, second and last commit. Last commit was deemed
pointless, first and second are already merged.
- rebased on top of modified first commit (changes in the wrappers)
Michal Wilczynski (6):
ACPI: AC: Remove unnecessary checks
ACPI: AC: Use string_choices API instead of ternary operator
ACPI: AC: Replace acpi_driver with platform_driver
ACPI: AC: Rename ACPI device from device to adev
ACPI: NFIT: Replace acpi_driver with platform_driver
ACPI: NFIT: Remove redundant call to to_acpi_dev()
drivers/acpi/ac.c | 103 +++++++++++++++++----------------------
drivers/acpi/nfit/core.c | 38 +++++++--------
2 files changed, 64 insertions(+), 77 deletions(-)
--
2.41.0
next reply other threads:[~2023-10-11 8:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 8:33 Michal Wilczynski [this message]
2023-10-11 8:33 ` [PATCH v3 1/6] ACPI: AC: Remove unnecessary checks Michal Wilczynski
2023-10-13 17:33 ` Rafael J. Wysocki
2023-10-11 8:33 ` [PATCH v3 2/6] ACPI: AC: Use string_choices API instead of ternary operator Michal Wilczynski
2023-10-13 17:35 ` Rafael J. Wysocki
2023-10-11 8:33 ` [PATCH v3 3/6] ACPI: AC: Replace acpi_driver with platform_driver Michal Wilczynski
2023-10-11 8:33 ` [PATCH v3 4/6] ACPI: AC: Rename ACPI device from device to adev Michal Wilczynski
2023-10-17 13:47 ` Rafael J. Wysocki
2023-10-11 8:33 ` [PATCH v3 5/6] ACPI: NFIT: Replace acpi_driver with platform_driver Michal Wilczynski
2023-10-11 8:33 ` [PATCH v3 6/6] ACPI: NFIT: Remove redundant call to to_acpi_dev() Michal Wilczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231011083334.3987477-1-michal.wilczynski@intel.com \
--to=michal.wilczynski@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).