NVDIMM Device and Persistent Memory development
 help / color / mirror / Atom feed
From: Xiao Yang <yangx.jy@fujitsu.com>
To: vishal.l.verma@intel.com, fan.ni@gmx.us, nvdimm@lists.linux.dev
Cc: linux-cxl@vger.kernel.org, Xiao Yang <yangx.jy@fujitsu.com>
Subject: [PATCH v2] daxctl: Remove unused memory_zone and mem_zone
Date: Fri, 11 Aug 2023 09:16:18 +0800	[thread overview]
Message-ID: <20230811011618.17290-1-yangx.jy@fujitsu.com> (raw)

The enum memory_zone definition and mem_zone variable
have never been used so remove them.

Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
---
 daxctl/device.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/daxctl/device.c b/daxctl/device.c
index d2d206b..8391343 100644
--- a/daxctl/device.c
+++ b/daxctl/device.c
@@ -55,12 +55,6 @@ static unsigned long flags;
 static struct mapping *maps = NULL;
 static long long nmaps = -1;
 
-enum memory_zone {
-	MEM_ZONE_MOVABLE,
-	MEM_ZONE_NORMAL,
-};
-static enum memory_zone mem_zone = MEM_ZONE_MOVABLE;
-
 enum device_action {
 	ACTION_RECONFIG,
 	ACTION_ONLINE,
@@ -469,8 +463,6 @@ static const char *parse_device_options(int argc, const char **argv,
 				align = __parse_size64(param.align, &units);
 		} else if (strcmp(param.mode, "system-ram") == 0) {
 			reconfig_mode = DAXCTL_DEV_MODE_RAM;
-			if (param.no_movable)
-				mem_zone = MEM_ZONE_NORMAL;
 		} else if (strcmp(param.mode, "devdax") == 0) {
 			reconfig_mode = DAXCTL_DEV_MODE_DEVDAX;
 			if (param.no_online) {
@@ -494,9 +486,6 @@ static const char *parse_device_options(int argc, const char **argv,
 			align = __parse_size64(param.align, &units);
 		/* fall through */
 	case ACTION_ONLINE:
-		if (param.no_movable)
-			mem_zone = MEM_ZONE_NORMAL;
-		/* fall through */
 	case ACTION_DESTROY:
 	case ACTION_OFFLINE:
 	case ACTION_DISABLE:
-- 
2.40.1


             reply	other threads:[~2023-08-11  1:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11  1:16 Xiao Yang [this message]
2023-10-09  9:40 ` [PATCH v2] daxctl: Remove unused memory_zone and mem_zone Xiao Yang (Fujitsu)
2023-12-01  4:12   ` Ira Weiny
2024-01-15  0:11     ` Xiao Yang
2024-01-17 20:09 ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230811011618.17290-1-yangx.jy@fujitsu.com \
    --to=yangx.jy@fujitsu.com \
    --cc=fan.ni@gmx.us \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).