From: Thorsten Leemhuis <regressions@leemhuis.info>
To: Chris Clayton <chris2553@googlemail.com>,
Mark O'Donovan <shiftee@posteo.net>,
linux-kernel@vger.kernel.org
Cc: ntfs3@lists.linux.dev, almaz.alexandrovich@paragon-software.com
Subject: Re: [PATCH] fs/ntfs3: fix build without CONFIG_NTFS3_LZX_XPRESS
Date: Wed, 21 Feb 2024 10:23:08 +0100 [thread overview]
Message-ID: <27ee0d22-18aa-453e-9020-76f4687bc044@leemhuis.info> (raw)
In-Reply-To: <0f3542a4-d558-447c-9dd7-cbb410c88e23@googlemail.com>
On 21.02.24 09:27, Chris Clayton wrote:
>
> This build regression also shows up, along with other problems, in a
> report to the ntfs3 list by the kernel test robot.[1]
>
> Also, as this patch seems not to have been picked up by the NTFS3
> maintainer I've added Thorsten Leemhuis so he can consider adding
> this egression to the tracker.
You mistyped my email address, but I noticed this by chance. :-D
Mark, could you do me a favor and send a v2 that picked up the Tested-by
and includes a Fixes: tag for the commit causing it? Then in case
Konstantin doesn't pick this up any time soon I'll ask Linus to pick
this up straight from the list.
Ciao, Thorsten
> [1]
> https://lore.kernel.org/ntfs3/202402211322.4GbTCzp8-lkp@intel.com/T/#u>
> Chris>
> On 19/02/2024 07:21, Chris Clayton wrote:
>> Hi.
>>
>> On 14/02/2024 22:45, Mark O'Donovan wrote:
>>> When CONFIG_NTFS3_LZX_XPRESS is not set then we get the following:
>>> fs/ntfs3/frecord.c:2460:16: error: unused variable ‘i_size’
>>>
>>> Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
>>> ---
>>> fs/ntfs3/frecord.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
>>> index 3b42938a9d3b..7f27382e0ce2 100644
>>> --- a/fs/ntfs3/frecord.c
>>> +++ b/fs/ntfs3/frecord.c
>>> @@ -2457,7 +2457,6 @@ int ni_read_frame(struct ntfs_inode *ni, u64 frame_vbo, struct page **pages,
>>> struct ATTR_LIST_ENTRY *le = NULL;
>>> struct runs_tree *run = &ni->file.run;
>>> u64 valid_size = ni->i_valid;
>>> - loff_t i_size = i_size_read(&ni->vfs_inode);
>>> u64 vbo_disk;
>>> size_t unc_size;
>>> u32 frame_size, i, npages_disk, ondisk_size;
>>> @@ -2509,6 +2508,7 @@ int ni_read_frame(struct ntfs_inode *ni, u64 frame_vbo, struct page **pages,
>>> err = -EOPNOTSUPP;
>>> goto out1;
>>> #else
>>> + loff_t i_size = i_size_read(&ni->vfs_inode);
>>> u32 frame_bits = ni_ext_compress_bits(ni);
>>> u64 frame64 = frame_vbo >> frame_bits;
>>> u64 frames, vbo_data;
>>>
>>> base-commit: 7e90b5c295ec1e47c8ad865429f046970c549a66
>>
>> Mark - Thanks for the patch.
>> Alex - Fixes a build bug introduced by 4fd6c08a16d7f1ba10212c9ef7bc73218144b463.
>>
>> Tested-by: Chris Clayton <chris2553@googlemail.com>
prev parent reply other threads:[~2024-02-21 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 22:45 [PATCH] fs/ntfs3: fix build without CONFIG_NTFS3_LZX_XPRESS Mark O'Donovan
2024-02-19 7:21 ` Chris Clayton
2024-02-21 8:27 ` Chris Clayton
2024-02-21 9:23 ` Thorsten Leemhuis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27ee0d22-18aa-453e-9020-76f4687bc044@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=chris2553@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=shiftee@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).