ntb.lists.linux.dev archive mirror
 help / color / mirror / Atom feed

From: "Yang.Lee" <yang.lee@linux.alibaba.com>
To: jdmason <jdmason@kudzu.us>, Logan Gunthorpe <logang@deltatee.com>
Cc: "dave.jiang" <dave.jiang@intel.com>, allenbh <allenbh@gmail.com>,
	linux-ntb <linux-ntb@googlegroups.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: 回复：[PATCH 2/2] NTB: Fix an error code in ntb_msit_probe()
Date: Mon, 07 Jun 2021 13:58:11 +0800	[thread overview]
Message-ID: <f39ea413-ac8a-430a-ba3d-9c197b3584ba.yang.lee@linux.alibaba.com> (raw)
In-Reply-To: <490f9031-7a12-6031-7262-f38cd96cb502@deltatee.com>

[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]

Hi,
I have sent a V2 patch. 

Thanks for your review.
------------------------------------------------------------------
发件人：Logan Gunthorpe <logang@deltatee.com>
发送时间：2021年6月5日(星期六) 00:21
收件人：Yang Li <yang.lee@linux.alibaba.com>; jdmason <jdmason@kudzu.us>
抄　送：dave.jiang <dave.jiang@intel.com>; allenbh <allenbh@gmail.com>; linux-ntb <linux-ntb@googlegroups.com>; linux-kernel <linux-kernel@vger.kernel.org>
主　题：Re: [PATCH 2/2] NTB: Fix an error code in ntb_msit_probe()




On 2021-06-04 4:20 a.m., Yang Li wrote:
> When the value of nm->isr_ctx is false, the value of ret is 0.
> So, we set ret to -ENOMEM to indicate this error.
> 
> Clean up smatch warning:
> drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing error
> code 'ret'.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/ntb/test/ntb_msi_test.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ntb/test/ntb_msi_test.c b/drivers/ntb/test/ntb_msi_test.c
> index 7095ecd..5f9e0be 100644
> --- a/drivers/ntb/test/ntb_msi_test.c
> +++ b/drivers/ntb/test/ntb_msi_test.c
> @@ -369,8 +369,10 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb)
>   if (ret)
>    goto remove_dbgfs;
>  
> - if (!nm->isr_ctx)
> + if (!nm->isr_ctx) {
> +  return -ENOMEM;
>    goto remove_dbgfs;

I think you made a typo here. You probably meant ret = -ENOMEM.

Thanks,

Logan


[-- Attachment #2: Type: text/html, Size: 4006 bytes --]

next prev parent reply	other threads:[~2021-06-07  5:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 10:20 [PATCH 1/2] NTB: perf: Fix an error code in perf_setup_inbuf() Yang Li
2021-06-04 10:20 ` [PATCH 2/2] NTB: Fix an error code in ntb_msit_probe() Yang Li
2021-06-04 15:18   ` Logan Gunthorpe
2021-06-07  5:58     ` Yang.Lee [this message]
2021-06-05 18:05 ` [PATCH 1/2] NTB: perf: Fix an error code in perf_setup_inbuf() Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f39ea413-ac8a-430a-ba3d-9c197b3584ba.yang.lee@linux.alibaba.com \
    --to=yang.lee@linux.alibaba.com \
    --cc=allenbh@gmail.com \
    --cc=dave.jiang@intel.com \
    --cc=jdmason@kudzu.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntb@googlegroups.com \
    --cc=logang@deltatee.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).