From: Dave Jiang <dave.jiang@intel.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
jdmason@kudzu.us, allenbh@gmail.com, error27@gmail.com
Cc: ntb@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NTB: ntb_tool: Add check for devm_kcalloc
Date: Mon, 28 Nov 2022 08:37:29 -0700 [thread overview]
Message-ID: <f27edbcf-91b6-3a9a-7fb3-96298ebb6009@intel.com> (raw)
In-Reply-To: <20221122033244.5777-1-jiasheng@iscas.ac.cn>
On 11/21/2022 8:32 PM, Jiasheng Jiang wrote:
> As the devm_kcalloc may return NULL pointer,
> it should be better to add check for the return
> value, as same as the others.
>
> Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/ntb/test/ntb_tool.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
> index 5ee0afa621a9..eeeb4b1c97d2 100644
> --- a/drivers/ntb/test/ntb_tool.c
> +++ b/drivers/ntb/test/ntb_tool.c
> @@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
> tc->peers[pidx].outmws =
> devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt,
> sizeof(*tc->peers[pidx].outmws), GFP_KERNEL);
> + if (tc->peers[pidx].outmws == NULL)
> + return -ENOMEM;
>
> for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) {
> tc->peers[pidx].outmws[widx].pidx = pidx;
prev parent reply other threads:[~2022-11-28 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 3:32 [PATCH] NTB: ntb_tool: Add check for devm_kcalloc Jiasheng Jiang
2022-11-25 11:49 ` Serge Semin
2022-11-28 15:37 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f27edbcf-91b6-3a9a-7fb3-96298ebb6009@intel.com \
--to=dave.jiang@intel.com \
--cc=allenbh@gmail.com \
--cc=error27@gmail.com \
--cc=jdmason@kudzu.us \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=ntb@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).