From: Dave Jiang <dave.jiang@intel.com>
To: Yang Yingliang <yangyingliang@huawei.com>, ntb@lists.linux.dev
Cc: jdmason@kudzu.us, allenbh@gmail.com
Subject: Re: [PATCH] NTB: ntb_transport: fix possible memory leak while device_register() fails
Date: Thu, 10 Nov 2022 08:33:35 -0700 [thread overview]
Message-ID: <d2b68fe0-214f-5464-f687-985dc6e7ccb8@intel.com> (raw)
In-Reply-To: <20221110151917.399214-1-yangyingliang@huawei.com>
On 11/10/2022 7:19 AM, Yang Yingliang wrote:
> If device_register() returns error, the name allocated by
> dev_set_name() need be freed. As comment of device_register()
> says, it should use put_device() to give up the reference in
> the error path. So fix this by calling put_device(), then the
> name can be freed in kobject_cleanup(), and client_dev is freed
> in ntb_transport_client_release().
>
> Fixes: fce8a7bb5b4b ("PCI-Express Non-Transparent Bridge Support")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/ntb/ntb_transport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> index a9b97ebc71ac..2abd2235bbca 100644
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -410,7 +410,7 @@ int ntb_transport_register_client_dev(char *device_name)
>
> rc = device_register(dev);
> if (rc) {
> - kfree(client_dev);
> + put_device(dev);
> goto err;
> }
>
prev parent reply other threads:[~2022-11-10 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 15:19 [PATCH] NTB: ntb_transport: fix possible memory leak while device_register() fails Yang Yingliang
2022-11-10 15:33 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2b68fe0-214f-5464-f687-985dc6e7ccb8@intel.com \
--to=dave.jiang@intel.com \
--cc=allenbh@gmail.com \
--cc=jdmason@kudzu.us \
--cc=ntb@lists.linux.dev \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).