From: Jon Mason <jdmason@kudzu.us>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Dinghao Liu <dinghao.liu@zju.edu.cn>,
kjlu@umn.edu, Allen Hubbe <allenbh@gmail.com>,
linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ntb: intel: Fix memleak in intel_ntb_pci_probe
Date: Mon, 24 Aug 2020 10:48:45 -0400 [thread overview]
Message-ID: <20200824144844.GA27238@kudzu.us> (raw)
In-Reply-To: <396e55a5-7ebe-1e81-b1b6-9a53cd885a8a@intel.com>
On Mon, Aug 24, 2020 at 07:37:56AM -0700, Dave Jiang wrote:
>
>
> On 8/22/2020 11:55 PM, Dinghao Liu wrote:
> > The default error branch of a series of pdev_is_gen calls
> > should free ndev just like what we've done in these calls.
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
>
> Thanks Dinghao
> Acked-by: Dave Jiang <dave.jiang@intel.com>
Added to my ntb branch.
I added
Fixes: 26bfe3d0b227 ("ntb: intel: Add Icelake (gen4) support for Intel NTB")
Thanks,
Jon
>
> > ---
> > drivers/ntb/hw/intel/ntb_hw_gen1.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/ntb/hw/intel/ntb_hw_gen1.c b/drivers/ntb/hw/intel/ntb_hw_gen1.c
> > index 3185efeab487..093dd20057b9 100644
> > --- a/drivers/ntb/hw/intel/ntb_hw_gen1.c
> > +++ b/drivers/ntb/hw/intel/ntb_hw_gen1.c
> > @@ -1893,7 +1893,7 @@ static int intel_ntb_pci_probe(struct pci_dev *pdev,
> > goto err_init_dev;
> > } else {
> > rc = -EINVAL;
> > - goto err_ndev;
> > + goto err_init_pci;
> > }
> > ndev_reset_unsafe_flags(ndev);
> >
prev parent reply other threads:[~2020-08-24 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 6:55 [PATCH] ntb: intel: Fix memleak in intel_ntb_pci_probe Dinghao Liu
2020-08-24 14:37 ` Dave Jiang
2020-08-24 14:48 ` Jon Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824144844.GA27238@kudzu.us \
--to=jdmason@kudzu.us \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).