* [Nouveau] [PATCH] drm/nouveau/devinit: Move assignment outside if condition
[not found] <20230711024429.78508-1-xujianghui@cdjrlc.com>
@ 2023-07-11 2:45 ` sunran001
0 siblings, 0 replies; only message in thread
From: sunran001 @ 2023-07-11 2:45 UTC (permalink / raw
To: airlied, daniel; +Cc: nouveau, linux-kernel, dri-devel
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c
index 1410befd2285..8185e10efc49 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c
@@ -61,7 +61,8 @@ nv05_devinit_meminit(struct nvkm_devinit *init)
}
strap = (nvkm_rd32(device, 0x101000) & 0x0000003c) >> 2;
- if ((data = bmp_mem_init_table(bios))) {
+ data = bmp_mem_init_table(bios);
+ if (data) {
ramcfg[0] = nvbios_rd08(bios, data + 2 * strap + 0);
ramcfg[1] = nvbios_rd08(bios, data + 2 * strap + 1);
} else {
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-07-11 2:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230711024429.78508-1-xujianghui@cdjrlc.com>
2023-07-11 2:45 ` [Nouveau] [PATCH] drm/nouveau/devinit: Move assignment outside if condition sunran001
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).