* [Nouveau] [PATCH drm-misc-next] drm/nouveau: uvmm: fix unset region pointer on remap
@ 2023-08-20 22:29 Danilo Krummrich
2023-08-21 2:53 ` Dave Airlie
0 siblings, 1 reply; 2+ messages in thread
From: Danilo Krummrich @ 2023-08-20 22:29 UTC (permalink / raw
To: airlied, daniel, bskeggs, kherbst, lyude; +Cc: nouveau, linux-kernel, dri-devel
Transfer the region pointer of a uvma to the new uvma(s) on re-map to
prevent potential shader faults when the re-mapped uvma(s) are unmapped.
Signed-off-by: Danilo Krummrich <dakr@redhat.com>
---
drivers/gpu/drm/nouveau/nouveau_uvmm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/nouveau/nouveau_uvmm.c b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
index 3a1e8538f205..aae780e4a4aa 100644
--- a/drivers/gpu/drm/nouveau/nouveau_uvmm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
@@ -639,6 +639,7 @@ nouveau_uvmm_sm_prepare(struct nouveau_uvmm *uvmm,
struct drm_gpuva *va = r->unmap->va;
struct uvmm_map_args remap_args = {
.kind = uvma_from_va(va)->kind,
+ .region = uvma_from_va(va)->region,
};
u64 ustart = va->va.addr;
u64 urange = va->va.range;
base-commit: 25205087df1ffe06ccea9302944ed1f77dc68c6f
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Nouveau] [PATCH drm-misc-next] drm/nouveau: uvmm: fix unset region pointer on remap
2023-08-20 22:29 [Nouveau] [PATCH drm-misc-next] drm/nouveau: uvmm: fix unset region pointer on remap Danilo Krummrich
@ 2023-08-21 2:53 ` Dave Airlie
0 siblings, 0 replies; 2+ messages in thread
From: Dave Airlie @ 2023-08-21 2:53 UTC (permalink / raw
To: Danilo Krummrich; +Cc: nouveau, linux-kernel, dri-devel, bskeggs, daniel
Reviewed-by: Dave Airlie <airlied@redhat.com>
On Mon, 21 Aug 2023 at 08:29, Danilo Krummrich <dakr@redhat.com> wrote:
>
> Transfer the region pointer of a uvma to the new uvma(s) on re-map to
> prevent potential shader faults when the re-mapped uvma(s) are unmapped.
>
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_uvmm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_uvmm.c b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> index 3a1e8538f205..aae780e4a4aa 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> @@ -639,6 +639,7 @@ nouveau_uvmm_sm_prepare(struct nouveau_uvmm *uvmm,
> struct drm_gpuva *va = r->unmap->va;
> struct uvmm_map_args remap_args = {
> .kind = uvma_from_va(va)->kind,
> + .region = uvma_from_va(va)->region,
> };
> u64 ustart = va->va.addr;
> u64 urange = va->va.range;
>
> base-commit: 25205087df1ffe06ccea9302944ed1f77dc68c6f
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-21 2:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-20 22:29 [Nouveau] [PATCH drm-misc-next] drm/nouveau: uvmm: fix unset region pointer on remap Danilo Krummrich
2023-08-21 2:53 ` Dave Airlie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).