netfilter.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kerin Millar <kfm@plushkava.net>
To: Tim Mooney <Tim.Mooney@ndsu.edu>
Cc: netfilter@vger.kernel.org
Subject: Re: converting iptables/ip6tables to efficient nftables rules
Date: Sun, 30 Jul 2023 22:14:47 +0100	[thread overview]
Message-ID: <20230730221447.af1b866bdddfe794be4d9b47@plushkava.net> (raw)
In-Reply-To: <924b35f-bda5-6ae5-efe-d05a8de7aec@ndsu.edu>

On Sun, 30 Jul 2023 15:30:14 -0500 (CDT)
Tim Mooney <Tim.Mooney@ndsu.edu> wrote:

> 
> All-
> 
> I haven't been able to find anywhere in the nftables wiki that talks
> about "Dos and Don'ts" from an efficiency perspective, especially for
> people that may be coming from iptables/ip6tables to nftables.  If it's
> there and I've missed it, please point me at it.
> 
> I have a mix of 32 iptables and ip6tables rules on a RHEL 7 box that I
> want to convert to nftables for RHEL 9 (kernel 5.14.0 + Red Hat vendor
> sauce, nftables 1.0.4).
> 
> The obvious thing to do would be to just directly translate each rule to
> nftables, and have 32 nftables rules.
> 
> However, the iptables rules are all pairs of
> 
>  	-A ports_allow -p tcp -m tcp -s X.Y.0.0/16 --dport 80 -j ACCEPT
>  	-A ports_allow -p tcp -m tcp -s X.Y.0.0/16 --dport 443 -j ACCEPT
> 
>  	-A ports_allow -p tcp -m tcp -s A.B.C.D/32 --dport 80 -j ACCEPT
>  	-A ports_allow -p tcp -m tcp -s A.B.C.D/32 --dport 443 -j ACCEPT
> 
> So I could cut the number of ntables rules in half just by using
> 
>  	dport { 80, 443 }
> 
> in the translated rule.
> 
> The question is, *is it more efficient*, from a packet processing
> perspective, to do that?  My guess is that it is, but can anyone with
> expertise confirm?  If it is more efficient, what type of efficiency
> improvement are we talking about, roughly?

# nft -d netlink -c -f - <<<'table ip t { chain c { ip saddr 10.0.0.0/16 tcp dport { 80, 443 } accept; }; }'
ip (null) (null) use 0
__set%d t 3 size 2
__set%d t 0
	element 00005000  : 0 [end]	element 0000bb01  : 0 [end]
ip t c
  [ payload load 2b @ network header + 12 => reg 1 ]
  [ cmp eq reg 1 0x0000000a ]
  [ meta load l4proto => reg 1 ]
  [ cmp eq reg 1 0x00000006 ]
  [ payload load 2b @ transport header + 2 => reg 1 ]
  [ lookup reg 1 set __set%d ]
  [ immediate reg 0 accept ]

Unsurprisingly, repeating the rule can be shown to demonstrate twice the number of instructions. You may find it difficult to measure the difference, however.

> 
> Similarly, all of the rules list CIDR ranges or individual IPs, though
> there are a mix of IPv4 and IPv6 ranges.  I therefore could greatly reduce
> the number of rules by creating a couple of named sets, one for IPv4 and
> one for IPv6, and match the 'ip saddr' against the sets.

You are definitely on the right track. Maps and/or verdict maps incorporating concatenations of the form "ipv4_addr . inet_service" and "ipv6_addr . inet_service" might also prove useful, depending on your exact requirements.

-- 
Kerin Millar

       reply	other threads:[~2023-07-30 21:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <924b35f-bda5-6ae5-efe-d05a8de7aec@ndsu.edu>
2023-07-30 21:14 ` Kerin Millar [this message]
2023-08-02 18:37   ` converting iptables/ip6tables to efficient nftables rules Tim Mooney
2023-07-31 12:57 ` Florian Westphal
2023-08-02 18:48   ` Tim Mooney
2023-07-30 20:30 Tim Mooney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230730221447.af1b866bdddfe794be4d9b47@plushkava.net \
    --to=kfm@plushkava.net \
    --cc=Tim.Mooney@ndsu.edu \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).