From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] json: Fix for memleak in __binop_expr_json
Date: Thu, 25 Apr 2024 12:48:59 +0200 [thread overview]
Message-ID: <Zio1G1lpge3YGsVm@orbyte.nwl.cc> (raw)
In-Reply-To: <ZimD2x6aaf29ZTyJ@calendula>
On Thu, Apr 25, 2024 at 12:12:43AM +0200, Pablo Neira Ayuso wrote:
> On Wed, Apr 24, 2024 at 11:58:21PM +0200, Phil Sutter wrote:
> > When merging the JSON arrays generated for LHS and RHS of nested binop
> > expressions, the emptied array objects leak if their reference is not
> > decremented.
> >
> > Fix this and tidy up other spots which did it right already by
> > introducing a json_array_extend wrapper.
>
> Thanks for fixing it up so quick, no more issues with tests/shell.
Thanks for verifying, patch applied.
prev parent reply other threads:[~2024-04-25 10:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 21:58 [nft PATCH] json: Fix for memleak in __binop_expr_json Phil Sutter
2024-04-24 22:12 ` Pablo Neira Ayuso
2024-04-25 10:48 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zio1G1lpge3YGsVm@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).