From: Phil Sutter <phil@nwl.cc>
To: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH 1/2] xlate: Improve redundant l4proto match avoidance
Date: Thu, 11 Apr 2024 12:16:08 +0200 [thread overview]
Message-ID: <Zhe4aMxp_wO8On0C@orbyte.nwl.cc> (raw)
In-Reply-To: <20240305171059.12795-1-phil@nwl.cc>
On Tue, Mar 05, 2024 at 06:10:58PM +0100, Phil Sutter wrote:
> xtables-translate tries to avoid 'ip protocol'/'meta l4proto' matches if
> following expressions add this as dependency anyway. E.g.:
>
> | # iptables-translate -A FOO -p tcp -m tcp --dport 22 -j ACCEPT
> | nft 'add rule ip filter FOO tcp dport 22 counter accept'
>
> This worked by searching protocol name in loaded matches, but that
> approach is flawed as the protocol name and corresponding extension may
> differ ("mobility-header" vs. "mh"). Improve this by searching for all
> names (cached or resolved) for a given protocol number.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Series applied.
prev parent reply other threads:[~2024-04-11 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 17:10 [iptables PATCH 1/2] xlate: Improve redundant l4proto match avoidance Phil Sutter
2024-03-05 17:10 ` [iptables PATCH 2/2] xlate: libip6t_mh: Fix and simplify plain '-m mh' match Phil Sutter
2024-04-11 10:16 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zhe4aMxp_wO8On0C@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).