From: Neels Hofmeyr <nhofmeyr@sysmocom.de>
To: netfilter-devel@vger.kernel.org
Subject: [RFC nftables PATCH]: fix a2x: ERROR: missing --destination-dir: ./doc
Date: Fri, 8 Mar 2024 00:54:27 +0100 [thread overview]
Message-ID: <ZepTs5Rj0bXqQvSo@my.box> (raw)
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
Since recently, I'm getting this build error from nftables, quite definitely
because I am building in a separate directory, and not in the source tree
itself.
GEN doc/nft.8
GEN doc/libnftables-json.5
GEN doc/libnftables.3
a2x: ERROR: missing --destination-dir: ./doc
make[2]: *** [Makefile:1922: doc/nft.8] Error 1
May I suggest attached patch.
An alternative might be an entry in AC_CONFIG_FILES? In the source trees at
osmocom we usually have a Makefile generated in each output dir, which solves
any missing directory problems.
I haven't investigated the cause, maybe it is some change on my system that
suddenly exposes this; there was some serious package upgrading going on half
an hour ago.
Thanks!
~N
--
- Neels Hofmeyr <nhofmeyr@sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschäftsführer / Managing Directors: Harald Welte
[-- Attachment #2: 0001-mkdir-builddir-doc.patch --]
[-- Type: text/x-diff, Size: 696 bytes --]
From b15204aa58c09d2a9368aa6c074be086fc481ece Mon Sep 17 00:00:00 2001
From: Neels Hofmeyr <nhofmeyr@sysmocom.de>
Date: Fri, 8 Mar 2024 00:42:50 +0100
Subject: [PATCH] mkdir $(builddir}/doc
When building separately from the source tree (as in ../src/configure),
the 'doc' dir is not present from just the source tree. Create the dir
before calling a2x.
---
Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.am b/Makefile.am
index 688a9849..fef1d8d1 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -342,6 +342,7 @@ EXTRA_DIST += \
CLEANFILES += doc/*~
doc/nft.8: $(ASCIIDOCS)
+ mkdir -p ${builddir}/doc
$(AM_V_GEN)$(A2X) $(A2X_OPTS_MANPAGE) $<
.adoc.3:
--
2.43.0
next reply other threads:[~2024-03-08 0:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 23:54 Neels Hofmeyr [this message]
2024-03-08 11:45 ` [RFC nftables PATCH]: fix a2x: ERROR: missing --destination-dir: ./doc Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZepTs5Rj0bXqQvSo@my.box \
--to=nhofmeyr@sysmocom.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).