From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH xtables-nft v2] extensions: xt_socket: add txlate support for socket match
Date: Wed, 6 Mar 2024 17:12:05 +0100 [thread overview]
Message-ID: <ZeiV1RaT7Ld-KxXh@orbyte.nwl.cc> (raw)
In-Reply-To: <20240306154207.GD4420@breakpoint.cc>
On Wed, Mar 06, 2024 at 04:42:07PM +0100, Florian Westphal wrote:
> Phil Sutter <phil@nwl.cc> wrote:
> > On Wed, Mar 06, 2024 at 11:11:25AM +0100, Florian Westphal wrote:
> > > +static int socket_mt_xlate(struct xt_xlate *xl, const struct xt_xlate_mt_params *params)
> > > +{
> > > + const struct xt_socket_mtinfo3 *info = (const void *)params->match->data;
> > > + const char *space = "";
> >
> > The whole "leading space or not" handling is not necessary, I made
> > xt_xlate_add() insert leading space automatically if the first
> > character is alpha-numeric or a brace.
>
> Perfect, I'll push this out after removing the extra handling.
Acked-by: Phil Sutter <phil@nwl.cc>
prev parent reply other threads:[~2024-03-06 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 10:11 [PATCH xtables-nft v2] extensions: xt_socket: add txlate support for socket match Florian Westphal
2024-03-06 14:52 ` Phil Sutter
2024-03-06 15:42 ` Florian Westphal
2024-03-06 16:12 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeiV1RaT7Ld-KxXh@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).