From: Jason Xing <kerneljasonxing@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: edumazet@google.com, pablo@netfilter.org, kadlec@netfilter.org,
kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next] netfilter: conntrack: avoid sending RST to reply out-of-window skb
Date: Sat, 9 Mar 2024 08:37:59 +0800 [thread overview]
Message-ID: <CAL+tcoDv_tOAdjwpCCuBkgSCAn4rj4wnTWTB17DY0RpXnQ=p5w@mail.gmail.com> (raw)
In-Reply-To: <20240308224657.GO4420@breakpoint.cc>
On Sat, Mar 9, 2024 at 6:47 AM Florian Westphal <fw@strlen.de> wrote:
>
> Jason Xing <kerneljasonxing@gmail.com> wrote:
> > > connection. Feel free to send patches that replace drop with -accept
> > > where possible/where it makes sense, but I don't think the
> > > TCP_CONNTRACK_SYN_SENT one can reasonably be avoided.
> >
> > Oh, are you suggesting replacing NF_DROP with -NF_ACCEPT in
> > nf_conntrack_dccp_packet()?
>
> It would be more consistent with what tcp and sctp trackers are
> doing, but this should not matter in practice (the packet is malformed).
Okay, I will take some time to check the sctp part. BTW, just like one
of previous emails said, I noticed there are two points in DCCP part
which is not consistent with TCP part, so I submitted one simple patch
[1] to do it.
[1]: https://lore.kernel.org/all/20240308092915.9751-1-kerneljasonxing@gmail.com/
>
> > > + case NFCT_TCP_INVALID: {
> > > + verdict = -NF_ACCEPT;
> > > + if (ct->status & IPS_NAT_MASK)
> > > + res = NF_DROP; /* skb would miss nat transformation */
> >
> > Above line, I guess, should be 'verdict = NF_DROP'?
>
> Yes.
>
> > Great! I think your draft patch makes sense really, which takes NAT
> > into consideration.
>
> You could submit this officially and we could give it a try and see if
> anyone complains down the road.
Great :)
Thanks,
Jason
prev parent reply other threads:[~2024-03-09 0:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 9:07 [PATCH net-next] netfilter: conntrack: avoid sending RST to reply out-of-window skb Jason Xing
2024-03-07 9:33 ` Florian Westphal
2024-03-07 11:02 ` Jason Xing
2024-03-07 12:00 ` Florian Westphal
2024-03-07 13:33 ` Jason Xing
2024-03-07 14:10 ` Florian Westphal
2024-03-07 15:11 ` Jason Xing
2024-03-07 15:34 ` Jozsef Kadlecsik
2024-03-07 15:59 ` Jason Xing
2024-03-07 19:00 ` Jozsef Kadlecsik
2024-03-08 0:42 ` Jason Xing
2024-03-08 8:59 ` Jason Xing
2024-03-08 22:46 ` Florian Westphal
2024-03-09 0:37 ` Jason Xing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL+tcoDv_tOAdjwpCCuBkgSCAn4rj4wnTWTB17DY0RpXnQ=p5w@mail.gmail.com' \
--to=kerneljasonxing@gmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).