Netdev Archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Jakub Kicinski <kuba@kernel.org>
Cc: io-uring@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCHSET RFC 0/4] Propagate back queue status on accept
Date: Mon, 13 May 2024 18:24:38 -0600	[thread overview]
Message-ID: <b4bb08a5-8213-4b31-870a-f4f24f7a2c4f@kernel.dk> (raw)
In-Reply-To: <20240513171347.711741c7@kernel.org>

On 5/13/24 6:13 PM, Jakub Kicinski wrote:
> On Thu,  9 May 2024 12:00:25 -0600 Jens Axboe wrote:
>> With io_uring, one thing we can do is tell userspace whether or not
>> there's more data left in a socket after a receive is done. This is
>> useful for applications to now, and it also helps make multishot receive
>> requests more efficient by eliminating that last failed retry when the
>> socket has no more data left. This is propagated by setting the
>> IORING_CQE_F_SOCK_NONEMPTY flag, and is driven by setting
>> msghdr->msg_get_inq and having the protocol fill out msghdr->msg_inq in
>> that case.
>>
>> For accept, there's a similar issue in that we'd like to know if there
>> are more connections to accept after the current one has been accepted.
>> Both because we can tell userspace about it, but also to drive multishot
>> accept retries more efficiently, similar to recv/recvmsg.
>>
>> This series starts by changing the proto/proto_ops accept prototypes
>> to eliminate flags/errp/kern and replace it with a structure that
>> encompasses all of them.
> 
> Acked-by: Jakub Kicinski <kuba@kernel.org>
> 
> Feel free to submit for 6.10, or LMK if you want me to send the first
> 3 to Linus.

Thanks! I'll send them in later this merge window (post the net-next
changes).

-- 
Jens Axboe


      reply	other threads:[~2024-05-14  0:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-09 18:00 [PATCHSET RFC 0/4] Propagate back queue status on accept Jens Axboe
2024-05-09 18:00 ` [PATCH 1/4] net: change proto and proto_ops accept type Jens Axboe
2024-05-09 18:00 ` [PATCH 2/4] net: have do_accept() take a struct proto_accept_arg argument Jens Axboe
2024-05-09 18:00 ` [PATCH 3/4] net: pass back whether socket was empty post accept Jens Axboe
2024-05-09 18:00 ` [PATCH 4/4] io_uring/net: wire up IORING_CQE_F_SOCK_NONEMPTY for accept Jens Axboe
2024-05-14  0:13 ` [PATCHSET RFC 0/4] Propagate back queue status on accept Jakub Kicinski
2024-05-14  0:24   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4bb08a5-8213-4b31-870a-f4f24f7a2c4f@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).