From: Thomas Gessler <thomas.gessler@brueckmann-gmbh.de>
To: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Gessler <thomas.gessler@brueckmann-gmbh.de>,
MD Danish Anwar <danishanwar@ti.com>,
Ravi Gunasekaran <r-gunasekaran@ti.com>
Subject: [PATCH 1/2] net: phy: dp83869: Add PHY ID for chip revision 3
Date: Tue, 14 May 2024 14:27:27 +0200 [thread overview]
Message-ID: <20240514122728.1490156-1-thomas.gessler@brueckmann-gmbh.de> (raw)
The recent silicon revision 3 of the DP83869 has a different PHY ID
which has to be added to the driver in order for the PHY to be detected.
There appear to be no documented differences between the revisions,
although there are some discussions in the TI forum about different
behavior for some registers.
Signed-off-by: Thomas Gessler <thomas.gessler@brueckmann-gmbh.de>
---
drivers/net/phy/dp83869.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
index d7aaefb5226b..d248a13c1749 100644
--- a/drivers/net/phy/dp83869.c
+++ b/drivers/net/phy/dp83869.c
@@ -15,7 +15,8 @@
#include <dt-bindings/net/ti-dp83869.h>
-#define DP83869_PHY_ID 0x2000a0f1
+#define DP83869REV1_PHY_ID 0x2000a0f1
+#define DP83869REV3_PHY_ID 0x2000a0f3
#define DP83561_PHY_ID 0x2000a1a4
#define DP83869_DEVADDR 0x1f
@@ -909,14 +910,16 @@ static int dp83869_phy_reset(struct phy_device *phydev)
}
static struct phy_driver dp83869_driver[] = {
- DP83869_PHY_DRIVER(DP83869_PHY_ID, "TI DP83869"),
+ DP83869_PHY_DRIVER(DP83869REV1_PHY_ID, "TI DP83869 Rev. 1"),
+ DP83869_PHY_DRIVER(DP83869REV3_PHY_ID, "TI DP83869 Rev. 3"),
DP83869_PHY_DRIVER(DP83561_PHY_ID, "TI DP83561-SP"),
};
module_phy_driver(dp83869_driver);
static struct mdio_device_id __maybe_unused dp83869_tbl[] = {
- { PHY_ID_MATCH_MODEL(DP83869_PHY_ID) },
+ { PHY_ID_MATCH_MODEL(DP83869REV1_PHY_ID) },
+ { PHY_ID_MATCH_MODEL(DP83869REV3_PHY_ID) },
{ PHY_ID_MATCH_MODEL(DP83561_PHY_ID) },
{ }
};
--
2.34.1
next reply other threads:[~2024-05-14 12:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 12:27 Thomas Gessler [this message]
2024-05-14 12:27 ` [PATCH 2/2] net: phy: dp83869: Fix RGMII-SGMII and 1000BASE-X Thomas Gessler
2024-05-14 12:56 ` Andrew Lunn
2024-05-15 8:15 ` Thomas Geßler
2024-05-15 15:10 ` Andrew Lunn
2024-05-14 13:05 ` Russell King (Oracle)
2024-05-15 8:45 ` Thomas Geßler
2024-05-14 13:08 ` Andrew Lunn
2024-05-15 7:47 ` Thomas Geßler
2024-05-14 12:47 ` [PATCH 1/2] net: phy: dp83869: Add PHY ID for chip revision 3 Andrew Lunn
2024-05-15 7:04 ` Thomas Geßler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240514122728.1490156-1-thomas.gessler@brueckmann-gmbh.de \
--to=thomas.gessler@brueckmann-gmbh.de \
--cc=andrew@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).