From: Simon Horman <horms@kernel.org>
To: Anshumali Gaur <agaur@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sunil Goutham <sgoutham@marvell.com>,
Linu Cherian <lcherian@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Jerin Jacob <jerinj@marvell.com>, hariprasad <hkelam@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH] octeontx2-af: Add debugfs support to dump NIX TM topology
Date: Tue, 14 May 2024 12:44:51 +0100 [thread overview]
Message-ID: <20240514114451.GF2787@kernel.org> (raw)
In-Reply-To: <20240514095434.31445-1-agaur@marvell.com>
On Tue, May 14, 2024 at 03:24:34PM +0530, Anshumali Gaur wrote:
> This patch adds support to dump NIX transmit queue topology.
> There are multiple levels of scheduling/shaping supported by
> NIX and a packet traverses through multiple levels before sending
> the packet out. At each level, there are set of scheduling/shaping
> rules applied to a packet flow.
>
> Each packet traverses through multiple levels
> SQ->SMQ->Tl4->Tl3->TL2->Tl1 and these levels are mapped in a parent-child
> relationship.
>
> This patch dumps the debug information related to all TM Levels in
> the following way.
>
> Example:
> $ echo <nixlf> > /sys/kernel/debug/octeontx2/nix/tm_tree
> $ cat /sys/kernel/debug/octeontx2/nix/tm_tree
>
> A more desriptive set of registers at each level can be dumped
> in the following way.
>
> Example:
> $ echo <nixlf> > /sys/kernel/debug/octeontx2/nix/tm_topo
> $ cat /sys/kernel/debug/octeontx2/nix/tm_topo
>
> Signed-off-by: Anshumali Gaur <agaur@marvell.com>
## Form letter - net-next-closed
(Adapted from text by Jakub)
The merge window for v6.10 has begun and therefore net-next is closed
for new drivers, features, code refactoring and optimizations.
We are currently accepting bug fixes only.
Please repost when net-next reopens after May 27th.
RFC patches sent for review only are welcome at any time.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
## End form letter
Also, as this patch seems to be for net-next, please include that in the
subject.
[PATCH net-next] ...
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
...
> +/*dumps given tm_tree registers*/
> +static int rvu_dbg_nix_tm_tree_display(struct seq_file *m, void *unused)
> +{
> + int qidx, nixlf, rc, id, max_id = 0;
> + struct nix_hw *nix_hw = m->private;
> + struct rvu *rvu = nix_hw->rvu;
> + struct nix_aq_enq_req aq_req;
> + struct nix_aq_enq_rsp rsp;
> + struct rvu_pfvf *pfvf;
> + u16 pcifunc;
> +
> + nixlf = rvu->rvu_dbg.nix_tm_ctx.lf;
> + id = rvu->rvu_dbg.nix_tm_ctx.id;
> +
> + if (!rvu_dbg_is_valid_lf(rvu, nix_hw->blkaddr, nixlf, &pcifunc))
> + return -EINVAL;
> +
> + pfvf = rvu_get_pfvf(rvu, pcifunc);
> + max_id = pfvf->sq_ctx->qsize;
> +
> + memset(&aq_req, 0, sizeof(struct nix_aq_enq_req));
> + aq_req.hdr.pcifunc = pcifunc;
> + aq_req.ctype = NIX_AQ_CTYPE_SQ;
> + aq_req.op = NIX_AQ_INSTOP_READ;
> + seq_printf(m, "pcifunc is 0x%x\n", pcifunc);
> + for (qidx = id; qidx < max_id; qidx++) {
> + aq_req.qidx = qidx;
> + rc = rvu_mbox_handler_nix_aq_enq(rvu, &aq_req, &rsp);
> +
> + /* Skip SQ's if not initialized */
> + if (!test_bit(qidx, pfvf->sq_bmap))
> + continue;
nit: The indentation of the lines immediately above is not
consistent with the code around it.
Flagged by Smatch.
> +
> + if (rc) {
> + seq_printf(m, "Failed to read SQ(%d) context\n",
> + aq_req.qidx);
> + continue;
> + }
> + print_tm_tree(m, &rsp, aq_req.qidx);
> + }
> + return 0;
> +}
...
> +/*dumps given tm_topo registers*/
> +static int rvu_dbg_nix_tm_topo_display(struct seq_file *m, void *unused)
> +{
> + struct nix_hw *nix_hw = m->private;
> + struct rvu *rvu = nix_hw->rvu;
> + struct nix_aq_enq_req aq_req;
> + struct nix_txsch *txsch;
> + int nixlf, lvl, schq;
> + u16 pcifunc;
> +
> + nixlf = rvu->rvu_dbg.nix_tm_ctx.lf;
> +
> + if (!rvu_dbg_is_valid_lf(rvu, nix_hw->blkaddr, nixlf, &pcifunc))
> + return -EINVAL;
> +
> + memset(&aq_req, 0, sizeof(struct nix_aq_enq_req));
> + aq_req.hdr.pcifunc = pcifunc;
> + aq_req.ctype = NIX_AQ_CTYPE_SQ;
> + aq_req.op = NIX_AQ_INSTOP_READ;
> + seq_printf(m, "pcifunc is 0x%x\n", pcifunc);
> +
> + for (lvl = 0; lvl < NIX_TXSCH_LVL_CNT; lvl++) {
> + txsch = &nix_hw->txsch[lvl];
> + for (schq = 0; schq < txsch->schq.max; schq++) {
> + if (TXSCH_MAP_FUNC(txsch->pfvf_map[schq]) == pcifunc)
> + print_tm_topo(m, schq, lvl);
Here too.
> + }
> + }
> + return 0;
> +}
--
pw-bot: changes-requested
prev parent reply other threads:[~2024-05-14 11:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 9:54 [PATCH] octeontx2-af: Add debugfs support to dump NIX TM topology Anshumali Gaur
2024-05-14 11:44 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240514114451.GF2787@kernel.org \
--to=horms@kernel.org \
--cc=agaur@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).