From: Jakub Kicinski <kuba@kernel.org>
To: "Martin Fäcknitz" <faecknitz@hotsplots.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] net: mhi: set skb mac header before entering RX path
Date: Mon, 13 May 2024 16:38:44 -0700 [thread overview]
Message-ID: <20240513163844.402a926d@kernel.org> (raw)
In-Reply-To: <20240513133830.26285-1-faecknitz@hotsplots.de>
On Mon, 13 May 2024 15:38:30 +0200 Martin Fäcknitz wrote:
> skb->mac_header must be set before passing the skb to the network stack,
> because skb->mac_len is calculated from skb->mac_header in
> __netif_receive_skb_core.
>
> Some network stack components, like xfrm, are using skb->mac_len to
> check for an existing MAC header, which doesn't exist in this case. This
> leads to memory corruption.
Could you add a Fixes tag identifying the commit where the buggy code
was added? And please make sure to CC the relevant maintainers (I mean
the maintainers of the MHI code, specifically) on v2.
--
pw-bot: cr
prev parent reply other threads:[~2024-05-13 23:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 13:38 [PATCH net] net: mhi: set skb mac header before entering RX path Martin Fäcknitz
2024-05-13 23:38 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513163844.402a926d@kernel.org \
--to=kuba@kernel.org \
--cc=faecknitz@hotsplots.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).