From: Jakub Kicinski <kuba@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
linux@armlinux.org.uk, horms@kernel.org, andrew@lunn.ch,
netdev@vger.kernel.org, mengyuanlou@net-swift.com,
Sai Krishna <saikrishnag@marvell.com>
Subject: Re: [PATCH net v3 2/3] net: wangxun: match VLAN CTAG and STAG features
Date: Mon, 13 May 2024 16:00:27 -0700 [thread overview]
Message-ID: <20240513160027.6a4a2350@kernel.org> (raw)
In-Reply-To: <20240510061751.2240-3-jiawenwu@trustnetic.com>
On Fri, 10 May 2024 14:17:50 +0800 Jiawen Wu wrote:
> Hardware requires VLAN CTAG and STAG configuration always matches. And
> whether VLAN CTAG or STAG changes, the configuration needs to be changed
> as well.
With this patch the resulting configuration will depend on the order of
actions. Basically the features will be disable if the last action is
either stag or ctag disable. This may cause to subtle bugs if some
refactoring changes the order of enable and disable.
It'd be better to turn both features on if _either_ feature was
requested. And require that _both_ are disabled before disabling.
--
pw-bot: cr
next prev parent reply other threads:[~2024-05-13 23:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 6:17 [PATCH net v3 0/3] Wangxun fixes Jiawen Wu
2024-05-10 6:17 ` [PATCH net v3 1/3] net: wangxun: fix to change Rx features Jiawen Wu
2024-05-10 6:17 ` [PATCH net v3 2/3] net: wangxun: match VLAN CTAG and STAG features Jiawen Wu
2024-05-13 23:00 ` Jakub Kicinski [this message]
2024-05-10 6:17 ` [PATCH net v3 3/3] net: txgbe: fix to control VLAN strip Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513160027.6a4a2350@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiawenwu@trustnetic.com \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saikrishnag@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).