* Fw: [Bug 15541] New: POLLIN bit is set when there is OOB data only
@ 2010-03-15 17:26 Stephen Hemminger
2010-03-19 3:29 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2010-03-15 17:26 UTC (permalink / raw
To: David Miller; +Cc: netdev
Begin forwarded message:
Date: Mon, 15 Mar 2010 16:19:44 GMT
From: bugzilla-daemon@bugzilla.kernel.org
To: shemminger@linux-foundation.org
Subject: [Bug 15541] New: POLLIN bit is set when there is OOB data only
http://bugzilla.kernel.org/show_bug.cgi?id=15541
Summary: POLLIN bit is set when there is OOB data only
Product: Networking
Version: 2.5
Kernel Version: 2.6.28, 2.6.32, 2.6.33
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: IPV4
AssignedTo: shemminger@linux-foundation.org
ReportedBy: Alexandra.Kossovsky@oktetlabs.ru
CC: davem@davemloft.net
Regression: Yes
Starting from 2.6.28, Linux kernel has incorrect behaviour when poll() is
called on TCP socket with out-of-band byte received.
When TCP socket has OOB byte available (and no normal data), old Linux,
Solaris, FreeBSD and other systems return POLLPRI bit without POLLRD. Starting
from 2.6.28, Linux returns POLLRD | POLLPRI | POLLRDNORM.
The broken commt is
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.28.y.git;a=commitdiff;h=c7004482e8dcb7c3c72666395cfa98a216a4fb70
.
Following 1-line patch fixes the problem:
--- a/net/ipv4/tcp.c 2010-03-15 19:13:45.000000000 +0300
+++ b/net/ipv4/tcp.c 2010-03-15 19:13:21.000000000 +0300
@@ -428,7 +428,7 @@
if (tp->urg_seq == tp->copied_seq &&
!sock_flag(sk, SOCK_URGINLINE) &&
tp->urg_data)
- target--;
+ target++;
/* Potential race condition. If read of tp below will
* escape above sk->sk_state, we can be illegally awaken
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
--
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Bug 15541] New: POLLIN bit is set when there is OOB data only
2010-03-15 17:26 Fw: [Bug 15541] New: POLLIN bit is set when there is OOB data only Stephen Hemminger
@ 2010-03-19 3:29 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-03-19 3:29 UTC (permalink / raw
To: shemminger; +Cc: netdev
Applied to net-2.6 and queued up for -stable, thanks for
forwarding this Stephen.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-19 3:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-15 17:26 Fw: [Bug 15541] New: POLLIN bit is set when there is OOB data only Stephen Hemminger
2010-03-19 3:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).