Netdev Archive mirror
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Gabi Falk <gabifalk@gmx.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 iproute2] bridge/vlan.c: bridge/vlan.c: fix build with gcc 14 on musl systems
Date: Tue, 14 May 2024 05:30:28 +0000	[thread overview]
Message-ID: <171566462879.15721.11797098361423504270.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240510143613.1531283-1-gabifalk@gmx.com>

Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:

On Fri, 10 May 2024 14:36:12 +0000 you wrote:
> On glibc based systems the definition of 'struct timeval' is pulled in
> with inclusion of <stdlib.h> header, but on musl based systems it
> doesn't work this way.  Missing definition triggers an
> incompatible-pointer-types error with gcc 14 (warning on previous
> versions of gcc):
> 
> ../include/json_print.h:80:30: warning: 'struct timeval' declared inside parameter list will not be visible outside of this definition or declaration
>    80 | _PRINT_FUNC(tv, const struct timeval *)
>       |                              ^~~~~~~
> ../include/json_print.h:50:37: note: in definition of macro '_PRINT_FUNC'
>    50 |                                     type value);                        \
>       |                                     ^~~~
> ../include/json_print.h:80:30: warning: 'struct timeval' declared inside parameter list will not be visible outside of this definition or declaration
>    80 | _PRINT_FUNC(tv, const struct timeval *)
>       |                              ^~~~~~~
> ../include/json_print.h:55:45: note: in definition of macro '_PRINT_FUNC'
>    55 |                                             type value)                 \
>       |                                             ^~~~
> ../include/json_print.h: In function 'print_tv':
> ../include/json_print.h:58:48: error: passing argument 5 of 'print_color_tv' from incompatible pointer type [-Wincompatible-pointer-types]
>    58 |                                                value);                  \
>       |                                                ^~~~~
>       |                                                |
>       |                                                const struct timeval *
> 
> [...]

Here is the summary with links:
  - [v2,iproute2] bridge/vlan.c: bridge/vlan.c: fix build with gcc 14 on musl systems
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=53a89bfd86ff

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      reply	other threads:[~2024-05-14  5:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10 14:23 [PATCH iproute2] bridge/vlan.c: fix build with gcc 14 on musl systems Gabi Falk
2024-05-10 14:36 ` [PATCH v2 iproute2] bridge/vlan.c: " Gabi Falk
2024-05-14  5:30   ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171566462879.15721.11797098361423504270.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=gabifalk@gmx.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).