From: Geliang Tang <geliang@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v9 0/8] refactor mptcp bpf tests
Date: Mon, 22 Apr 2024 15:05:22 +0800 [thread overview]
Message-ID: <febc0751efc11641e353216ff22fe94e6d623811.camel@kernel.org> (raw)
In-Reply-To: <72ba1395-fa5f-489a-872d-5dcb1727da5f@kernel.org>
Hi Matt,
On Sat, 2024-04-20 at 11:12 +0200, Matthieu Baerts wrote:
> Hi Geliang,
>
> On 20/04/2024 02:18, Geliang Tang wrote:
> > Hi Matt,
> >
> > On Fri, 2024-04-19 at 11:58 +0200, Matthieu Baerts wrote:
> > > Hi Geliang, Mat,
> > >
> > > On 17/04/2024 04:38, Geliang Tang wrote:
> > > > From: Geliang Tang <tanggeliang@kylinos.cn>
> > > >
> > > > v9:
> > > > - extract a new helper test_bpf_sched() from
> > > > MPTCP_SCHED_TEST() to
> > > > make
> > > > the macro simpler as Mat suggested. (thanks)
> > > > - squash MPTCP_SCHED_TEST() into "selftests/bpf: Add bpf_first
> > > > scheduler & test", not "selftests/bpf: Add bpf scheduler
> > > > test"
> > > > to
> > > > avoid a build error "test_bpf_sched is not used".
> > > Thank you for the v9, and the review!
> > >
> > > @Geliang: there were a lot of Git (TopGit) manipulations here,
> > > please
> > > check that the result is the expected one.
> >
> > Thank you for applying these patches. I know there must be many
> > conflicts inside. Thank you for updating my email address too. All
> > patches merged well and all tests passed.
>
> Thank you for having checked!
>
> > >
> > >
> > > New patch for t/upstream:
> > >
> > > - d0432b7d2bb0: selftests/bpf: Add RUN_MPTCP_TEST macro
> >
> > Please insert this commit "selftests/bpf: Add RUN_MPTCP_TEST macro"
> > before "mptcp: add sched_data helpers" so that it can be upstreamed
> > in advance with "setsockopt per subflow: BPF" series being
> > reviewed,
> > without waiting for BPF scheduler APIs to be updated. WDYT?
>
> I don't think we need to move it: there are no other patches
> modifying
> the BPF selftests before that one. So we should be safe regarding
> conflicts.
Yes, I agree.
>
> We can indeed send it with "setsockopt per subflow: BPF" series.
> These
> patches can be applied before "selftests/bpf: Add RUN_MPTCP_TEST
> macro",
> in the "patches for net-next" section when they will be marked as
> ready.
"setsockopt per subflow: BPF" series could be merged in this order:
1 selftests/bpf: Add mptcp subflow example
2 selftests/bpf: Add RUN_MPTCP_TEST macro
3 selftests/bpf: Add mptcp subflow subtest
4 selftests/bpf: Handle SIGINT when creating netns
Thanks,
-Geliang
>
> Cheers,
> Matt
prev parent reply other threads:[~2024-04-22 7:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 2:38 [PATCH mptcp-next v9 0/8] refactor mptcp bpf tests Geliang Tang
2024-04-17 2:38 ` [PATCH mptcp-next v9 1/8] selftests/bpf: Add RUN_MPTCP_TEST macro Geliang Tang
2024-04-18 16:42 ` Mat Martineau
2024-04-17 2:38 ` [PATCH mptcp-next v9 2/8] Squash to "selftests/bpf: Add bpf scheduler test" 1 verify Geliang Tang
2024-04-17 2:38 ` [PATCH mptcp-next v9 3/8] Squash to "selftests/bpf: Add bpf scheduler test" 2 time Geliang Tang
2024-04-17 2:38 ` [PATCH mptcp-next v9 4/8] Squash to "selftests/bpf: Add bpf_first scheduler & test" Geliang Tang
2024-04-18 0:23 ` Mat Martineau
2024-04-17 2:38 ` [PATCH mptcp-next v9 5/8] Squash to "selftests/bpf: Add bpf_bkup " Geliang Tang
2024-04-17 2:38 ` [PATCH mptcp-next v9 6/8] Squash to "selftests/bpf: Add bpf_rr " Geliang Tang
2024-04-17 2:38 ` [PATCH mptcp-next v9 7/8] Squash to "selftests/bpf: Add bpf_red " Geliang Tang
2024-04-17 2:38 ` [PATCH mptcp-next v9 8/8] Squash to "selftests/bpf: Add bpf_burst " Geliang Tang
2024-04-17 3:25 ` [PATCH mptcp-next v9 0/8] refactor mptcp bpf tests MPTCP CI
2024-04-19 9:58 ` Matthieu Baerts
2024-04-20 0:18 ` Geliang Tang
2024-04-20 9:12 ` Matthieu Baerts
2024-04-22 7:05 ` Geliang Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=febc0751efc11641e353216ff22fe94e6d623811.camel@kernel.org \
--to=geliang@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).