From: Paolo Abeni <pabeni@redhat.com>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: Christoph Paasch <cpaasch@apple.com>,
mptcp@lists.linux.dev, Mat Martineau <martineau@kernel.org>
Subject: Re: [PATCH mptcp-net v3] mptcp: ensure snd_nxt is properly initialized on connect
Date: Fri, 19 Apr 2024 18:58:15 +0200 [thread overview]
Message-ID: <b41d1e68d1010c4735ea0d596c814168cd79f5d8.camel@redhat.com> (raw)
In-Reply-To: <f979f4ba-d075-4ec7-95b9-3edfa0fb354b@kernel.org>
On Fri, 2024-04-19 at 17:15 +0200, Matthieu Baerts wrote:
> Hi Paolo, Mat, Christoph,
>
> On 18/04/2024 09:44, Paolo Abeni wrote:
> > Christoph reported a splat hinting at a corrupted snd_una:
> Thank you for the patch, the review, and the bug report + test.
>
> I forgot to send a notification after I applied this patch. In between,
> the CI already validated this, and both the build for export and
> export-net have the same issue with Packetdrill (fastopen):
>
> - export:
>
> > not ok 32 packetdrill: mptcp/fastopen/server-TCP_FASTOPEN-cookie-req.pkt (ipv4-mapped-v6)
> > # server-TCP_FASTOPEN-cookie-req.pkt:23: error handling packet: live packet field ipv4_total_length: expected: 48 (0x30) vs actual: 64 (0x40)
> > # script packet: 0.660855 . 1:1(0) ack 1 <dss dack4 3007449510 flags: A>
> > # actual packet: 0.651162 . 1:1(0) ack 1 win 256 <dss dack4 3007449509 dsn8 4250179620018965011 ssn 0 dll 1 no_checksum flags: MmAF,nop,nop>
>
> https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8752422517
>
> - export-net:
>
> > not ok 32 packetdrill: mptcp/fastopen/server-TCP_FASTOPEN-cookie-req.pkt (ipv4-mapped-v6)
> > # server-TCP_FASTOPEN-cookie-req.pkt:23: error handling packet: live packet field ipv4_total_length: expected: 48 (0x30) vs actual: 64 (0x40)
> > # script packet: 0.667029 . 1:1(0) ack 1 <dss dack4 3007449510 flags: A>
> > # actual packet: 0.665988 . 1:1(0) ack 1 win 256 <dss dack4 3007449509 dsn8 4812888791396531368 ssn 0 dll 1 no_checksum flags: MmAF,nop,nop>
>
> https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8752426856
>
> Do you think this is linked?
I hope it's not, but the timing hints otherwise :( I'll try to have a
better look.
Thanks for the head-up!
Paolo
prev parent reply other threads:[~2024-04-19 16:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 7:44 [PATCH mptcp-net v3] mptcp: ensure snd_nxt is properly initialized on connect Paolo Abeni
2024-04-18 8:36 ` MPTCP CI
2024-04-18 16:59 ` Mat Martineau
2024-04-19 10:33 ` Paolo Abeni
2024-04-19 10:37 ` Matthieu Baerts
2024-04-19 15:15 ` Matthieu Baerts
2024-04-19 16:58 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b41d1e68d1010c4735ea0d596c814168cd79f5d8.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=cpaasch@apple.com \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).