From: Matthieu Baerts <matttbe@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-net v2 0/2] mptcp: getsockopt(SO_KEEPALIVE) and TCP_KEEP* sockopts
Date: Fri, 10 May 2024 10:52:24 +0200 [thread overview]
Message-ID: <b2b35837-db28-42dc-abff-fa139c75c310@kernel.org> (raw)
In-Reply-To: <e5f65112c385549b57a53075db4a73ac728f4f79.camel@redhat.com>
Hi Paolo,
On 10/05/2024 10:32, Paolo Abeni wrote:
> On Thu, 2024-05-09 at 12:48 +0200, Matthieu Baerts (NGI0) wrote:
>> This is linked to a discussion we had a few weeks ago: not supporting
>> TCP_KEEP* socket options is preventing MPTCP to be used in some apps or
>> libraries like it was the case in GoLang recently.
>>
>> Supporting them is not difficult, it should have probably done before,
>> when SO_KEEPALIVE support has been added. Supporting them is easy and
>> isolated from the rest, it sounds safe enough to add a Fixes tag, and
>> check with the stable team to backport them. I understand it can be a
>> bit controversial, but it would unnecessary delay (1 or 2 years?) some
>> deployments, for something that simple.
>>
>> While at it, getsockopt(SO_KEEPALIVE) is now returning the expected
>> value.
(...)
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>
> LGTM, thanks!
>
> Acked-by: Paolo Abeni <pabeni@redhat.com>
Thank you for the review!
Now in our tree (fixes for net-next, in preparation for the next batch):
New patches for t/upstream:
- 1f3df7457803: mptcp: SO_KEEPALIVE: fix getsockopt support
- f246f7a50963: mptcp: fix full TCP keep-alive support
- Results: 18d3f4f7094a..ea351593813d (export)
Tests are now in progress:
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/2f64d8457b9c03ff3d78f3efb8da42f94ce7e277/checks
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2024-05-10 8:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 10:48 [PATCH mptcp-net v2 0/2] mptcp: getsockopt(SO_KEEPALIVE) and TCP_KEEP* sockopts Matthieu Baerts (NGI0)
2024-05-09 10:48 ` [PATCH mptcp-net v2 1/2] mptcp: SO_KEEPALIVE: fix getsockopt support Matthieu Baerts (NGI0)
2024-05-09 10:48 ` [PATCH mptcp-net v2 2/2] mptcp: fix full TCP keep-alive support Matthieu Baerts (NGI0)
2024-05-09 11:39 ` [PATCH mptcp-net v2 0/2] mptcp: getsockopt(SO_KEEPALIVE) and TCP_KEEP* sockopts MPTCP CI
2024-05-10 8:32 ` Paolo Abeni
2024-05-10 8:52 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2b35837-db28-42dc-abff-fa139c75c310@kernel.org \
--to=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).