From: Geliang Tang <geliang@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next 00/10] add helpers and vars in mptcp_lib.sh, final
Date: Sat, 16 Mar 2024 11:56:55 +0800 [thread overview]
Message-ID: <ZfUYhzbEdk0YGOi6@t480> (raw)
In-Reply-To: <d4ad6607-3a57-49cd-a0d6-de7f3ceb38c9@kernel.org>
Hi Matt,
On Wed, Mar 13, 2024 at 07:46:41PM +0100, Matthieu Baerts wrote:
> Hi Geliang,
>
> On 11/03/2024 02:48, Geliang Tang wrote:
> > From: Geliang Tang <tanggeliang@kylinos.cn>
> >
> > This is the last part for "add helpers and vars in mptcp_lib.sh" series,
> > add endpoint operation helpers into mptcp_lib.sh.
>
> Thank you for looking at that!
>
> I just did a review, see my different replies.
Thanks for your review. It's very useful. I just sent a v2, addressed all
your comments.
>
> In general, I think we should only add tests if they validate new code
> path on the kernel side, e.g. new feature. Having more tests means more
> code to maintain, a longer time to execute them, etc. Best to only add
> "valuable" ones.
I dropped them in v2.
>
> > Geliang Tang (10):
> > selftests: mptcp: export ip_mptcp to mptcp_lib
> > selftests: mptcp: get support for limits
> > selftests: mptcp: id support for show_endpoints
> > selftests: mptcp: addr support for change_endpoint
> > selftests: mptcp: netlink: fix positions of newline
> > selftests: mptcp: netlink: add outputs for ip_mptcp
> > selftests: mptcp: add endpoint_ops API helper
> > selftests: mptcp: use mptcp_lib_endpoint_ops
> > selftests: mptcp: add ip_mptcp option for more scripts
>
> I hope some people are going to validate that. I don't think our CI
> should always run these tests with and without this new '-i' option.
>
> Maybe once in a while, to validate the interface with 'ip mptcp' is
> still OK? Do you plan to do this check periodically? e.g. before a new
> version of 'iproute2'?
Sure, I can check them in the future.
Thanks,
-Geliang
>
>
> > selftests: mptcp: netlink: drop disable=SC2086
> >
> > .../testing/selftests/net/mptcp/mptcp_join.sh | 108 ++-----
> > .../testing/selftests/net/mptcp/mptcp_lib.sh | 166 ++++++++++
> > .../selftests/net/mptcp/mptcp_sockopt.sh | 34 ++-
> > .../testing/selftests/net/mptcp/pm_netlink.sh | 288 +++++++++++-------
> > .../selftests/net/mptcp/simult_flows.sh | 14 +-
> > 5 files changed, 401 insertions(+), 209 deletions(-)
> >
>
> Cheers,
> Matt
> --
> Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2024-03-16 3:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 1:48 [PATCH mptcp-next 00/10] add helpers and vars in mptcp_lib.sh, final Geliang Tang
2024-03-11 1:48 ` [PATCH mptcp-next 01/10] selftests: mptcp: export ip_mptcp to mptcp_lib Geliang Tang
2024-03-13 18:47 ` Matthieu Baerts
2024-03-11 1:48 ` [PATCH mptcp-next 02/10] selftests: mptcp: get support for limits Geliang Tang
2024-03-13 18:47 ` Matthieu Baerts
2024-03-11 1:48 ` [PATCH mptcp-next 03/10] selftests: mptcp: id support for show_endpoints Geliang Tang
2024-03-13 18:47 ` Matthieu Baerts
2024-03-11 1:48 ` [PATCH mptcp-next 04/10] selftests: mptcp: addr support for change_endpoint Geliang Tang
2024-03-13 18:48 ` Matthieu Baerts
2024-03-11 1:48 ` [PATCH mptcp-next 05/10] selftests: mptcp: netlink: fix positions of newline Geliang Tang
2024-03-11 1:48 ` [PATCH mptcp-next 06/10] selftests: mptcp: netlink: add outputs for ip_mptcp Geliang Tang
2024-03-13 18:49 ` Matthieu Baerts
2024-03-11 1:48 ` [PATCH mptcp-next 07/10] selftests: mptcp: add endpoint_ops API helper Geliang Tang
2024-03-13 18:50 ` Matthieu Baerts
2024-03-11 1:48 ` [PATCH mptcp-next 08/10] selftests: mptcp: use mptcp_lib_endpoint_ops Geliang Tang
2024-03-11 1:48 ` [PATCH mptcp-next 09/10] selftests: mptcp: add ip_mptcp option for more scripts Geliang Tang
2024-03-11 1:48 ` [PATCH mptcp-next 10/10] selftests: mptcp: netlink: drop disable=SC2086 Geliang Tang
2024-03-11 2:06 ` selftests: mptcp: netlink: drop disable=SC2086: Build Failure MPTCP CI
2024-03-11 2:44 ` selftests: mptcp: netlink: drop disable=SC2086: Tests Results MPTCP CI
2024-03-13 15:18 ` [PATCH mptcp-next 10/10] selftests: mptcp: netlink: drop disable=SC2086 MPTCP CI
2024-03-13 18:46 ` [PATCH mptcp-next 00/10] add helpers and vars in mptcp_lib.sh, final Matthieu Baerts
2024-03-16 3:56 ` Geliang Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfUYhzbEdk0YGOi6@t480 \
--to=geliang@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).