From: Geliang Tang <geliang@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH iperf3 v3] add MPTCPv1 support
Date: Tue, 12 Mar 2024 16:14:24 +0800 [thread overview]
Message-ID: <ZfAO4OKX8sjHTQW9@t480> (raw)
In-Reply-To: <4a1febfb-54e0-4d1f-ac56-e5fa4e1bdead@kernel.org>
On Tue, Mar 12, 2024 at 09:09:27AM +0100, Matthieu Baerts wrote:
> Hi Geliang,
>
> On 12/03/2024 08:27, Geliang Tang wrote:
> > Hi Matt,
> >
> > On Tue, Mar 12, 2024 at 08:10:28AM +0100, Matthieu Baerts wrote:
> >> Hi Geliang,
> >>
> >> 11 Mar 2024 08:04:05 Geliang Tang <geliang@kernel.org>:
> >>
> >>> The Multipath TCP (MPTCP) protocol (v1 / RFC 8684) has been added in
> >>> the upstream Linux kernel since v5.6.
> >>>
> >>> MPTCP is strongly tied to TCP, and the kernel APIs are almost the same.
> >>> The only required dependency is the 'IPPROTO_MPTCP' protocol number
> >>> definition, which should be provided by the netinet/in.h header if it
> >>> is recent enough.
> >>>
> >>> This patch adds a new flag '-m' or '--multipath' to support MPTCPv1.
> >>
> >> I just noticed you switched back to "multipath" instead of "mptcp".
> >> I think it is best to stick with "mptcp", because "multipath"
> >> is too vague, thus confusing: it could be multipath as in multiple
> >> flows, multicast, with other protocols like UDP, etc.
> >>
> >> Best to use "mptcp" everywhere: variables, strings, description, etc.
> >
> > Sure, I'll send a v4 to update the flag to '--mptcp'.
>
> Thanks!
>
> > But I don't know
> > how to update the pull request on github. Should I send another pull
> > request?
>
> No, please don't open a new pull request, nor close the old one, simply
> override your remote branch on GitHub (`git push --force`).
Sorry, I open a new one before reading this:
https://github.com/esnet/iperf/pull/1661
>
> >>> It can be used like this:>>>
> >>>> iperf3 -m -s
> >>>> iperf3 -m -c 127.0.0.1
> >>
> >> If the server doesn't have "-m", only the client, does it use MPTCP?
> >
> > Yes, it use MPTCP in this case. I just tested it.
>
> Great, thank you for having tested that!
>
> Cheers,
> Matt
> --
> Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2024-03-12 8:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 7:03 [PATCH iperf3 v3] add MPTCPv1 support Geliang Tang
2024-03-12 7:10 ` Matthieu Baerts
2024-03-12 7:27 ` Geliang Tang
2024-03-12 8:09 ` Matthieu Baerts
2024-03-12 8:14 ` Geliang Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfAO4OKX8sjHTQW9@t480 \
--to=geliang@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).