From: Jason Xing <kerneljasonxing@gmail.com>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: edumazet@google.com, dsahern@kernel.org, martineau@kernel.org,
geliang@kernel.org, kuba@kernel.org, pabeni@redhat.com,
davem@davemloft.net, rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, atenart@kernel.org,
horms@kernel.org, mptcp@lists.linux.dev, netdev@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next v8 5/7] mptcp: support rstreason for passive reset
Date: Tue, 23 Apr 2024 18:57:38 +0800 [thread overview]
Message-ID: <CAL+tcoC9kD8ZFkEJG2U=i6UrtxKzfQeFe5-q7pCfZ8SmM7arRQ@mail.gmail.com> (raw)
In-Reply-To: <4ce919ea-6110-4a84-8992-a72a9785c48b@kernel.org>
Hello Matthieu,
On Tue, Apr 23, 2024 at 6:02 PM Matthieu Baerts <matttbe@kernel.org> wrote:
>
> Hi Jason,
>
> On 23/04/2024 09:21, Jason Xing wrote:
> > From: Jason Xing <kernelxing@tencent.com>
> >
> > It relys on what reset options in the skb are as rfc8684 says. Reusing
>
> (if you have something else to fix, 'checkpatch.pl --codespell' reported
> a warning here: s/relys/relies/)
Thanks. Will fix it.
>
> > this logic can save us much energy. This patch replaces most of the prior
> > NOT_SPECIFIED reasons.
> >
> > Signed-off-by: Jason Xing <kernelxing@tencent.com>
> > ---
> > net/mptcp/protocol.h | 28 ++++++++++++++++++++++++++++
> > net/mptcp/subflow.c | 22 +++++++++++++++++-----
> > 2 files changed, 45 insertions(+), 5 deletions(-)
> >
> > diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
> > index fdfa843e2d88..bbcb8c068aae 100644
> > --- a/net/mptcp/protocol.h
> > +++ b/net/mptcp/protocol.h
> > @@ -581,6 +581,34 @@ mptcp_subflow_ctx_reset(struct mptcp_subflow_context *subflow)
> > WRITE_ONCE(subflow->local_id, -1);
> > }
> >
> > +/* Convert reset reasons in MPTCP to enum sk_rst_reason type */
> > +static inline enum sk_rst_reason
> > +sk_rst_convert_mptcp_reason(u32 reason)
> > +{
> > + switch (reason) {
> > + case MPTCP_RST_EUNSPEC:
> > + return SK_RST_REASON_MPTCP_RST_EUNSPEC;
> > + case MPTCP_RST_EMPTCP:
> > + return SK_RST_REASON_MPTCP_RST_EMPTCP;
> > + case MPTCP_RST_ERESOURCE:
> > + return SK_RST_REASON_MPTCP_RST_ERESOURCE;
> > + case MPTCP_RST_EPROHIBIT:
> > + return SK_RST_REASON_MPTCP_RST_EPROHIBIT;
> > + case MPTCP_RST_EWQ2BIG:
> > + return SK_RST_REASON_MPTCP_RST_EWQ2BIG;
> > + case MPTCP_RST_EBADPERF:
> > + return SK_RST_REASON_MPTCP_RST_EBADPERF;
> > + case MPTCP_RST_EMIDDLEBOX:
> > + return SK_RST_REASON_MPTCP_RST_EMIDDLEBOX;
> > + default:
> > + /**
>
> I guess here as well, it should be '/*' instead of '/**'. But I guess
> that's fine, this file is probably not scanned. Anyway, if you have to
> send a new version, please fix this as well.
Thanks for your help. I will.
>
> (Also, this helper might require '#include <net/rstreason.h>', but our
> CI is fine with it, it is also added in the next commit, and probably
> already included via include/net/request_sock.h. So I guess that's fine.)
Yes, If I need to submit the V9 patch, I will move it.
>
>
> Other than that, it looks good to me:
>
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Thanks for all the reviews :)
Thanks,
Jason
>
> Cheers,
> Matt
> --
> Sponsored by the NGI0 Core fund.
>
next prev parent reply other threads:[~2024-04-23 10:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 7:21 [PATCH net-next v8 0/7] Implement reset reason mechanism to detect Jason Xing
2024-04-23 7:21 ` [PATCH net-next v8 1/7] net: introduce rstreason to detect why the RST is sent Jason Xing
2024-04-23 9:59 ` Matthieu Baerts
2024-04-23 7:21 ` [PATCH net-next v8 2/7] rstreason: prepare for passive reset Jason Xing
2024-04-23 10:00 ` Matthieu Baerts
2024-04-23 7:21 ` [PATCH net-next v8 3/7] rstreason: prepare for active reset Jason Xing
2024-04-23 10:00 ` Matthieu Baerts
2024-04-23 7:21 ` [PATCH net-next v8 4/7] tcp: support rstreason for passive reset Jason Xing
2024-04-23 7:21 ` [PATCH net-next v8 5/7] mptcp: " Jason Xing
2024-04-23 10:02 ` Matthieu Baerts
2024-04-23 10:57 ` Jason Xing [this message]
2024-04-23 7:21 ` [PATCH net-next v8 6/7] mptcp: introducing a helper into active reset logic Jason Xing
2024-04-23 10:02 ` Matthieu Baerts
2024-04-23 7:21 ` [PATCH net-next v8 7/7] rstreason: make it work in trace world Jason Xing
2024-04-23 8:15 ` [PATCH net-next v8 0/7] Implement reset reason mechanism to detect MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL+tcoC9kD8ZFkEJG2U=i6UrtxKzfQeFe5-q7pCfZ8SmM7arRQ@mail.gmail.com' \
--to=kerneljasonxing@gmail.com \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=matttbe@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).